Optimize the loading of NexT.utils.getScript to avoid global namespace pollution

Author: stevenjoezhang

layout/_scripts/vendors.swig

@@ -26,10 +26,6 @@
   {%- set js_vendors.reading_progress = 'reading_progress/reading_progress.js' %}
 {%- endif %}
 
-{%- if theme.valine.enable %}
-  {%- set js_vendors.valine = '//unpkg.com/valine/dist/Valine.min.js' %}
-{%- endif %}
-
 {%- if theme.motion.enable %}
   {%- set js_vendors.velocity = 'velocity/velocity.min.js?v=1.2.1' %}
   {%- set js_vendors.velocity_ui = 'velocity/velocity.ui.min.js?v=1.2.1' %}

layout/_third-party/comments/disqusjs.swig

@@ -11,7 +11,7 @@
 {%- endif %}
 
 <script>
-  function initialDsq() {
+  NexT.utils.getScript('{{ disqusjs_js_url }}', function() {
     window.dsqjs = new DisqusJS({
       api: '{{ theme.disqusjs.api }}' || 'https://disqus.com/api/',
       apikey: '{{ theme.disqusjs.apikey }}',
@@ -20,7 +20,6 @@
       identifier: {{ page.path | json }},
       title: '{{ page.title | addslashes }}',
     });
-  }
-  NexT.utils.getScript('{{ disqusjs_js_url }}', initialDsq, window.DisqusJS);
+  }, window.DisqusJS);
 </script>
 {%- endif %}

layout/_third-party/comments/gitalk.swig

@@ -11,7 +11,7 @@
 {%- endif %}
 
 <script>
-  function initGitalk() {
+  NexT.utils.getScript('{{ gitalk_js_url }}', function() {
     var gitalk = new Gitalk({
       clientID: '{{ theme.gitalk.client_id }}',
       clientSecret: '{{ theme.gitalk.client_secret }}',
@@ -27,7 +27,6 @@
       distractionFreeMode: '{{ theme.gitalk.distraction_free_mode }}'
     });
     gitalk.render('gitalk-container');
-  }
-  NexT.utils.getScript('{{ gitalk_js_url }}', initGitalk, window.Gitalk);
+  }, window.Gitalk);
 </script>
 {%- endif %}

layout/_third-party/comments/valine.swig

@@ -1,4 +1,10 @@
+{%- set valine_uri = '//unpkg.com/valine/dist/Valine.min.js' %}
+{%- if theme.vendors.valine %}
+  {%- set valine_uri = theme.vendors.valine %}
+{%- endif %}
+
 <script>
+NexT.utils.getScript('{{ valine_uri }}', function() {
   var GUEST = ['nick', 'mail', 'link'];
   var guest = '{{ theme.valine.guest_info }}';
   guest = guest.split(',').filter(function(item) {
@@ -18,4 +24,5 @@
     lang: '{{ theme.valine.language }}' || 'zh-cn',
     path: location.pathname
   });
+}, window.Valine);
 </script>

layout/_third-party/tags/mermaid.swig

@@ -1,16 +1,15 @@
 {%- if theme.mermaid.enable %}
 <script{{ pjax }}>
-function embedMermaid() {
-  mermaid.initialize({
-    theme: '{{ theme.mermaid.theme }}',
-    logLevel: 3,
-    flowchart: { curve: 'linear' },
-    gantt: { axisFormat: '%m/%d/%Y' },
-    sequence: { actorMargin: 50 }
-  });
-}
 if ($('body').find('pre.mermaid').length) {
-  NexT.utils.getScript('{{ theme.mermaid.cdn }}', embedMermaid, window.mermaid);
+  NexT.utils.getScript('{{ theme.mermaid.cdn }}', function() {
+    mermaid.initialize({
+      theme: '{{ theme.mermaid.theme }}',
+      logLevel: 3,
+      flowchart: { curve: 'linear' },
+      gantt: { axisFormat: '%m/%d/%Y' },
+      sequence: { actorMargin: 50 }
+    });
+  }, window.mermaid);
 }
 </script>
 {%- endif %}

layout/_third-party/tags/pdf.swig

@@ -1,22 +1,21 @@
 {%- if theme.pdf.enable %}
 <script{{ pjax }}>
-function embedPDF() {
-  $('body').find('div.pdf').each(function(i, o) {
-    PDFObject.embed($(o).attr('target'), $(o), {
-      pdfOpenParams: {
-        navpanes: 0,
-        toolbar: 0,
-        statusbar: 0,
-        pagemode: 'thumbs',
-        view: 'FitH'
-      },
-      PDFJS_URL: '/lib/pdf/web/viewer.html',
-      height: $(o).attr('height') || '{{ theme.pdf.height }}'
-    });
-  });
-}
 if ($('body').find('div.pdf').length) {
-  NexT.utils.getScript('{{ theme.pdf.pdfobject.cdn }}', embedPDF, window.PDFObject);
+  NexT.utils.getScript('{{ theme.pdf.pdfobject.cdn }}', function() {
+    $('body').find('div.pdf').each(function(i, o) {
+      PDFObject.embed($(o).attr('target'), $(o), {
+        pdfOpenParams: {
+          navpanes: 0,
+          toolbar: 0,
+          statusbar: 0,
+          pagemode: 'thumbs',
+          view: 'FitH'
+        },
+        PDFJS_URL: '/lib/pdf/web/viewer.html',
+        height: $(o).attr('height') || '{{ theme.pdf.height }}'
+      });
+    });
+  }, window.PDFObject);
 }
 </script>
 {%- endif %}