From d892d1c6b09613e95faaaa27640a2b17a0768cb1 Mon Sep 17 00:00:00 2001 From: "Andres O. Vela" Date: Sun, 14 Feb 2021 15:10:52 +0100 Subject: [PATCH 1/2] Return DCError instead of BusWriteError on DC signal assertion errors --- CHANGELOG.md | 4 ++++ parallel-gpio/src/lib.rs | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b65de5e..c9db1e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] +### Changed + +- Return `DCError` instead of `BusWriteError` on errors (de-)asserting the DC signal in 8-bit GPIO interfaces + ## [v0.4.0] - 2020-05-25 ### Added diff --git a/parallel-gpio/src/lib.rs b/parallel-gpio/src/lib.rs index 43b6a77..cf5fe32 100644 --- a/parallel-gpio/src/lib.rs +++ b/parallel-gpio/src/lib.rs @@ -187,7 +187,7 @@ where { fn send_commands(&mut self, cmds: DataFormat<'_>) -> Result<(), DisplayError> { use byte_slice_cast::*; - self.dc.set_low().map_err(|_| DisplayError::BusWriteError)?; + self.dc.set_low().map_err(|_| DisplayError::DCError)?; match cmds { DataFormat::U8(slice) => slice.iter().try_for_each(|cmd| { self.wr.set_low().map_err(|_| DisplayError::BusWriteError)?; @@ -240,7 +240,7 @@ where use byte_slice_cast::*; self.dc .set_high() - .map_err(|_| DisplayError::BusWriteError)?; + .map_err(|_| DisplayError::DCError)?; match buf { DataFormat::U8(slice) => slice.iter().try_for_each(|d| { self.wr.set_low().map_err(|_| DisplayError::BusWriteError)?; From f5973903e3fb8286ea0e9c94e5a573dfbcfe7d4f Mon Sep 17 00:00:00 2001 From: "Andres O. Vela" Date: Sun, 14 Feb 2021 15:29:12 +0100 Subject: [PATCH 2/2] Ran cargo fmt --- parallel-gpio/src/lib.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/parallel-gpio/src/lib.rs b/parallel-gpio/src/lib.rs index cf5fe32..82a4d3e 100644 --- a/parallel-gpio/src/lib.rs +++ b/parallel-gpio/src/lib.rs @@ -238,9 +238,7 @@ where fn send_data(&mut self, buf: DataFormat<'_>) -> Result<(), DisplayError> { use byte_slice_cast::*; - self.dc - .set_high() - .map_err(|_| DisplayError::DCError)?; + self.dc.set_high().map_err(|_| DisplayError::DCError)?; match buf { DataFormat::U8(slice) => slice.iter().try_for_each(|d| { self.wr.set_low().map_err(|_| DisplayError::BusWriteError)?;