From da69c39e14752620e0174d5092a6bfff01c99c2a Mon Sep 17 00:00:00 2001 From: Adrian Bonislawski Date: Mon, 27 Jul 2026 19:12:09 +0200 Subject: [PATCH] tools: rimage: return a negative error code from elf_error() elf_error() negates its argument, so an already negative code was turned into a positive value that callers testing "ret < 0" take for success. Signed-off-by: Adrian Bonislawski --- tools/rimage/src/elf_file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/rimage/src/elf_file.c b/tools/rimage/src/elf_file.c index c40d3a69abfb..c68a7d3af4e6 100644 --- a/tools/rimage/src/elf_file.c +++ b/tools/rimage/src/elf_file.c @@ -95,13 +95,13 @@ static struct name_val p_flags[] = { * * @param elf elf file structure * @param msg error message - * @param error error code to return - * @return error code + * @param error positive errno value, or an already negative error code + * @return negative error code */ static int elf_error(const struct elf_file *elf, const char *msg, int error) { fprintf(stderr, "Error: %s: %s\n", elf->filename, msg); - return -error; + return error < 0 ? error : -error; } /**