Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ff20ca4

Browse files
authored
Merge pull request #95 from thestormforge/fix/activity-patch-request
Add logic for passing a correct activity patch request body
2 parents 3fa3fde + 705000c commit ff20ca4

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

pkg/api/applications/v2/activity.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,12 @@ type RefreshActivity struct {
105105
ActivityFailure
106106
}
107107

108+
type ActivityPatchRequest struct {
109+
Title string `json:"title"`
110+
// Data is a JSON-serializable value for internal metadata about the Activity
111+
Data any `json:"_stormforge,omitempty"`
112+
}
113+
108114
type ActivityFailure struct {
109115
FailureReason string `json:"failure_reason,omitempty"`
110116
FailureMessage string `json:"failure_message,omitempty"`

pkg/api/applications/v2/api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ type API interface {
108108
// DeleteActivity resolves application activity.
109109
DeleteActivity(ctx context.Context, u string) error
110110
// PatchApplicationActivity updates application activity.
111-
PatchApplicationActivity(ctx context.Context, u string, a ActivityFailure) error
111+
PatchApplicationActivity(ctx context.Context, u string, a ActivityPatchRequest) error
112112

113113
// SubscribeActivity returns a subscriber for the activity feed.
114114
SubscribeActivity(ctx context.Context, q ActivityFeedQuery) (Subscriber, error)

pkg/api/applications/v2/http.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ func (h *httpAPI) DeleteActivity(ctx context.Context, u string) error {
592592
}
593593
}
594594

595-
func (h *httpAPI) PatchApplicationActivity(ctx context.Context, u string, a ActivityFailure) error {
595+
func (h *httpAPI) PatchApplicationActivity(ctx context.Context, u string, a ActivityPatchRequest) error {
596596
req, err := httpNewJSONRequest(http.MethodPatch, u, a)
597597
if err != nil {
598598
return err

0 commit comments

Comments
 (0)