Code review with Gimantha, Thisaru and Tharik

Author: thil4n

app/src/main/java/io/ballerina/web3/cli/Cli.java

@@ -15,7 +15,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-
+// TODO: io.ballerina.lib.web3
 package io.ballerina.web3.cli;
 
 import io.ballerina.cli.BLauncherCmd;

app/src/main/java/io/ballerina/web3/generator/ClientGenerator.java

@@ -16,8 +16,12 @@
  * under the License.
  */
 
+ // TODO:  Latest copy writes
+
+
 package io.ballerina.web3.generator;
 
+// TODO:  import only specific classes rather than the whole package
 import io.ballerina.compiler.syntax.tree.*;
 import io.ballerina.tools.text.TextDocument;
 import io.ballerina.tools.text.TextDocuments;

app/src/main/java/io/ballerina/web3/generator/DynamicFunctionGenerator.java

@@ -40,10 +40,12 @@ private static String convertAbiTypeToBallerina(String abiType) {
                         return convertAbiTypeToBallerina(abiType.replace("[]", "")) + "[]";
                 }
 
+                // TODO : Use specific data types
                 return switch (abiType) {
                         case "uint256", "int256", "uint8", "int8", "uint16", "int16" -> "decimal";
                         case "bool" -> "boolean";
                         case "address" -> "string";
+                        // TODO: bytes -> byte array
                         case "string", "bytes" -> "string";
                         default -> "anydata"; // Fallback
                 };
@@ -56,10 +58,12 @@ private static String generateBallerinaReturnType(List<AbiOutput> outputs, Strin
 
                 // If there's only one output, return its native type
                 if (outputs.size() == 1) {
+                        // TODO: Handle error type
                         return convertAbiTypeToBallerina(outputs.get(0).getType()) + "|error?";
                 }
 
                 // If multiple outputs, generate a record type
+                // Todo : Record name first char cap
                 String recordName = functionName + "Response";
                 StringBuilder recordType = new StringBuilder("type ").append(recordName).append(" record {| ");
 
@@ -80,6 +84,7 @@ private static String generateResourceFunctionSignature(List<AbiInput> inputs, L
                 StringBuilder data = new StringBuilder();
 
                 // Define the function signature
+                // TODO:  isolated res func
                 data.append("resource isolated function post ").append(methodName).append("(");
 
                 // Add function parameters
@@ -108,6 +113,7 @@ private static String generateResourceFunctionSignature(List<AbiInput> inputs, L
         private static String generateDecodingLogic(List<AbiOutput> outputs) {
                 String outputType = outputs.get(0).getType(); // Assuming single output for simplicity
 
+                // TODO : Handle other outputs
                 switch (outputType) {
                         case "uint256":
                         case "int256":
@@ -118,7 +124,8 @@ private static String generateDecodingLogic(List<AbiOutput> outputs) {
                                 return "string result = \"0x\" + response.result.substring(26);\n"; // Last 20 bytes
                         case "string":
                                 return "string result = response.result.substring(2);\n";
-                        case "tuple[]":
+                                // TODO: handle tuple
+                                case "tuple[]":
                                 return "anydata[] result = []; // Not yet supported \n";
                         default:
                                 return "string result = response;\n // Unsupported type: " + outputType + "\n";

app/src/main/java/io/ballerina/web3/generator/Generator.java

@@ -28,6 +28,8 @@ public class Generator {
     public static void generate(List<AbiEntry> abiEntries, String outputDir) throws FormatterException {
         String sourceCode = ClientGenerator.generate(abiEntries);
 
+        // TODO : Use path for file.seperator
+        // TODO : Code gen dir
         FileUtils.writeToFile(outputDir + "/main.bal", sourceCode);
         FileUtils.copyResourceToOutput("utils.bal", outputDir);
     }

app/src/main/java/io/ballerina/web3/generator/utils/AbiUtils.java

@@ -17,6 +17,7 @@
  */
 
 package io.ballerina.web3.generator.utils;
+
 import java.nio.charset.StandardCharsets;
 import java.util.List;
 
@@ -32,6 +33,7 @@ public static String encodeParameters(List<AbiInput> params) {
             if (param instanceof Integer || param instanceof Long) {
                 paramEncoded = String.format("%064x", (Integer) param); // 64-character hex
             } else if (param instanceof Boolean) {
+                // TODO: Restruct
                 paramEncoded = ((Boolean) param) ? "0000000000000000000000000000000000000000000000000000000000000001"
                         : "0000000000000000000000000000000000000000000000000000000000000000";
             } else if (param instanceof String strParam) {
@@ -50,7 +52,6 @@ public static String encodeParameters(List<AbiInput> params) {
         return encodedParams.toString();
     }
 
-
     private static String stringToHex(String input) {
         byte[] bytes = input.getBytes(StandardCharsets.UTF_8);
         StringBuilder hexString = new StringBuilder();

app/src/main/java/io/ballerina/web3/generator/utils/BallerinaUtils.java

@@ -22,6 +22,7 @@
 
 public class BallerinaUtils {
     // List of Reserved Keywords in Ballerina
+    // TODO: use keywords from compiler
     private static final Set<String> RESERVED_KEYWORDS = Set.of(
             "function", "int", "boolean", "string", "record", "resource", "isolated",
             "error", "returns", "public", "private", "remote", "client", "self", "if", "else",