Breaking: drop 1.4 support; kill getVersion().

Closes #59 by removing our only dependency on version parsing.

Author: aseemk

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## Unreleased
 
+  - ***BREAKING:*** This library no longer supports Neo4j 1.4.
+
+  - ***BREAKING:*** `GraphDatabase::getVersion()` has been removed.
+    It was only used internally for Neo4j 1.4 support;
+    hopefully you had no need for it externally.
+
   - New `GraphDatabase` methods to create, read, and delete node and
     relationship indexes, e.g. `createNodeIndex()`, `getNodeIndexes()`, and
     `deleteNodeIndex()` respectively for nodes.

README.md

@@ -3,7 +3,7 @@
 This is a client library for accessing [Neo4j][], a graph database, from
 [Node.js][]. It uses Neo4j's [REST API][neo4j-rest-api].
 
-This library supports and has been tested against Neo4j 1.4 through Neo4j 1.9.
+This library supports and has been tested against Neo4j 1.5 through Neo4j 1.9.
 
 
 ## Installation

lib/GraphDatabase._coffee

@@ -106,25 +106,6 @@ module.exports = class GraphDatabase
         catch error
             throw adjustError error
 
-    #
-    # Fetch and "return" (via callback) the Neo4j version as a float.
-    #
-    # @note This doesn't preserve "milestone" information, e.g. "M06".
-    #
-    # @param callback {Function}
-    # @return {Number}
-    #
-    getVersion: (_) ->
-        try
-            services = @getServices _
-
-            # Neo4j 1.5 onwards report their version number here;
-            # if it's not there, assume Neo4j 1.4.
-            parseFloat services['neo4j_version'] or '1.4'
-
-        catch error
-            throw adjustError
-
     ### Nodes: ###
 
     #

lib/Node._coffee

@@ -127,28 +127,14 @@ module.exports = class Node extends PropertyContainer
                 throw new Error 'Node must exist before indexing.'
 
             services = @db.getServices _
-            version = @db.getVersion _
 
-            # old API:
-            if version <= 1.4
-                encodedKey = encodeURIComponent key
-                encodedValue = encodeURIComponent value
-                url = "#{services.node_index}/#{index}/#{encodedKey}/#{encodedValue}"
-
-                response = @_request.post
-                    url: url
-                    json: @self
-                , _
-
-            # new API:
-            else
-                response = @_request.post
-                    url: "#{services.node_index}/#{index}"
-                    json:
-                        key: key
-                        value: value
-                        uri: @self
-                , _
+            response = @_request.post
+                url: "#{services.node_index}/#{index}"
+                json:
+                    key: key
+                    value: value
+                    uri: @self
+            , _
 
             if response.statusCode isnt status.CREATED
                 # database error

lib/Relationship._coffee

@@ -103,28 +103,14 @@ module.exports = class Relationship extends PropertyContainer
                 throw new Error 'Relationship must exist before indexing properties'
 
             services = @db.getServices _
-            version = @db.getVersion _
-
-            # old API:
-            if version <= 1.4
-                encodedKey = encodeURIComponent key
-                encodedValue = encodeURIComponent value
-                url = "#{services.relationship_index}/#{index}/#{encodedKey}/#{encodedValue}"
-
-                response = @_request.post
-                    url: url
-                    json: @self
-                , _
-
-            # new API:
-            else
-                response = @_request.post
-                    url: "#{services.relationship_index}/#{index}"
-                    json:
-                        key: key
-                        value: value
-                        uri: @self
-                , _
+
+            response = @_request.post
+                url: "#{services.relationship_index}/#{index}"
+                json:
+                    key: key
+                    value: value
+                    uri: @self
+            , _
 
             if response.statusCode isnt status.CREATED
                 # database error