Skip to content

Commit e40ec1f

Browse files
authored
Merge pull request #29 from hansemannn/update-repo
Update changelog and versions, reformat iOS
2 parents 0ef7127 + b704b01 commit e40ec1f

File tree

6 files changed

+42
-41
lines changed

6 files changed

+42
-41
lines changed

android/documentation/changelog.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Change Log
22
<pre>
3-
v2.3.1 Fixed images not being recycled properly.
3+
v3.1.0 Added image rotation functionality, fixed images not being recycled properly.
44

5-
v2.3.0 Added image rotation functionality.
5+
v3.0.0 Rebuild module for SDK 6+ compatibility
66

77
v2.2.2 [MOD-2166] Recompiled module to solve crashes in Android 6.0
88

android/manifest

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
# this is your module manifest and used by Titanium
33
# during compilation, packaging, distribution, etc.
44
#
5-
version: 3.0.0
5+
version: 3.1.0
66
apiversion: 3
77
architectures: armeabi-v7a x86
88
description: Image Factory
99
author: Jeff English
1010
license: Apache License, Version 2.0
11-
copyright: Copyright (c) 2013-2016 by Appcelerator, Inc.
11+
copyright: Copyright (c) 2013-2017 by Appcelerator, Inc.
1212

1313

1414
# these should not be edited

ios/Classes/TiImagefactoryModule.m

Lines changed: 7 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -34,34 +34,7 @@ -(void)startup
3434
// you *must* call the superclass
3535
[super startup];
3636

37-
NSLog(@"[INFO] %@ loaded",self);
38-
}
39-
40-
-(void)shutdown:(id)sender
41-
{
42-
// this method is called when the module is being unloaded
43-
// typically this is during shutdown. make sure you don't do too
44-
// much processing here or the app will be quit forceably
45-
46-
// you *must* call the superclass
47-
[super shutdown:sender];
48-
}
49-
50-
#pragma mark Cleanup
51-
52-
-(void)dealloc
53-
{
54-
// release any resources that have been retained by the module
55-
[super dealloc];
56-
}
57-
58-
#pragma mark Internal Memory Management
59-
60-
-(void)didReceiveMemoryWarning:(NSNotification*)notification
61-
{
62-
// optionally release any resources that can be dynamically
63-
// reloaded once memory is available - such as caches
64-
[super didReceiveMemoryWarning:notification];
37+
NSLog(@"[DEBUG] %@ loaded",self);
6538
}
6639

6740
#pragma system properties
@@ -137,12 +110,12 @@ +(id)imageTransform:(TransformType)type withArgs:(id)args
137110

138111
#pragma mark Public Image Methods
139112

140-
-(id)imageWithRotation:(id)args
113+
- (id)imageWithRotation:(id)args
141114
{
142115
return [TiImagefactoryModule imageTransform:kTransformRotate withArgs:args];
143116
}
144117

145-
-(id)imageWithAlpha:(id)args
118+
- (id)imageWithAlpha:(id)args
146119
{
147120
return [TiImagefactoryModule imageTransform:kTransformAlpha withArgs:args];
148121
}
@@ -161,17 +134,17 @@ - (id)imageAsThumbnail:(id)args
161134
{
162135
return [TiImagefactoryModule imageTransform:kTransformThumbnail withArgs:args];}
163136

164-
-(id)imageAsResized:(id)args
137+
- (id)imageAsResized:(id)args
165138
{
166139
return [TiImagefactoryModule imageTransform:kTransformResize withArgs:args];
167140
}
168141

169-
-(id)imageAsCropped:(id)args
142+
- (id)imageAsCropped:(id)args
170143
{
171144
return [TiImagefactoryModule imageTransform:kTransformCrop withArgs:args];
172145
}
173146

174-
-(id)imageTransform:(id)args
147+
- (id)imageTransform:(id)args
175148
{
176149
enum Args {
177150
kArgBlob = 0,
@@ -196,7 +169,7 @@ -(id)imageTransform:(id)args
196169
return image ? [[[TiBlob alloc] initWithImage:image] autorelease] : nil;
197170
}
198171

199-
-(id)compress:(id)args
172+
- (id)compress:(id)args
200173
{
201174
enum Args {
202175
kArgBlob = 0,

ios/documentation/changelog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Change Log
22
<pre>
3-
v1.3.0 Added image rotation functionality.
3+
v1.3.0 Added image rotation functionality.
44

55
v1.2.0 [TIMOB-18092] Updated to build for 64bit
66

ios/imagefactory.xcodeproj/project.pbxproj

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@
193193
0867D690FE84028FC02AAC07 /* Project object */ = {
194194
isa = PBXProject;
195195
attributes = {
196-
LastUpgradeCheck = 0640;
196+
LastUpgradeCheck = 0830;
197197
};
198198
buildConfigurationList = 1DEB922208733DC00010E9CD /* Build configuration list for PBXProject "imagefactory" */;
199199
compatibilityVersion = "Xcode 3.2";
@@ -347,21 +347,35 @@
347347
i386,
348348
x86_64,
349349
);
350+
CLANG_WARN_BOOL_CONVERSION = YES;
351+
CLANG_WARN_CONSTANT_CONVERSION = YES;
352+
CLANG_WARN_EMPTY_BODY = YES;
353+
CLANG_WARN_ENUM_CONVERSION = YES;
354+
CLANG_WARN_INFINITE_RECURSION = YES;
355+
CLANG_WARN_INT_CONVERSION = YES;
356+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
357+
CLANG_WARN_UNREACHABLE_CODE = YES;
358+
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
350359
CODE_SIGN_IDENTITY = "iPhone Developer";
351360
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
352361
DSTROOT = /tmp/TiImagefactory.dst;
362+
ENABLE_STRICT_OBJC_MSGSEND = YES;
353363
GCC_C_LANGUAGE_STANDARD = c99;
364+
GCC_NO_COMMON_BLOCKS = YES;
354365
GCC_OPTIMIZATION_LEVEL = 0;
355366
GCC_PRECOMPILE_PREFIX_HEADER = YES;
356367
GCC_PREFIX_HEADER = TiImagefactory_Prefix.pch;
357368
GCC_PREPROCESSOR_DEFINITIONS = "TI_VERSION=$(TI_VERSION)";
358369
GCC_THUMB_SUPPORT = NO;
359370
GCC_TREAT_WARNINGS_AS_ERRORS = NO;
360371
GCC_VERSION = "";
372+
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
361373
GCC_WARN_ABOUT_RETURN_TYPE = NO;
362374
GCC_WARN_MISSING_PARENTHESES = NO;
363375
GCC_WARN_SHADOW = NO;
364376
GCC_WARN_STRICT_SELECTOR_MATCH = NO;
377+
GCC_WARN_UNDECLARED_SELECTOR = YES;
378+
GCC_WARN_UNINITIALIZED_AUTOS = YES;
365379
GCC_WARN_UNUSED_FUNCTION = YES;
366380
GCC_WARN_UNUSED_PARAMETER = NO;
367381
GCC_WARN_UNUSED_VALUE = NO;
@@ -394,19 +408,33 @@
394408
i386,
395409
x86_64,
396410
);
411+
CLANG_WARN_BOOL_CONVERSION = YES;
412+
CLANG_WARN_CONSTANT_CONVERSION = YES;
413+
CLANG_WARN_EMPTY_BODY = YES;
414+
CLANG_WARN_ENUM_CONVERSION = YES;
415+
CLANG_WARN_INFINITE_RECURSION = YES;
416+
CLANG_WARN_INT_CONVERSION = YES;
417+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
418+
CLANG_WARN_UNREACHABLE_CODE = YES;
419+
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
397420
DSTROOT = /tmp/TiImagefactory.dst;
421+
ENABLE_STRICT_OBJC_MSGSEND = YES;
398422
GCC_C_LANGUAGE_STANDARD = c99;
399423
GCC_MODEL_TUNING = G5;
424+
GCC_NO_COMMON_BLOCKS = YES;
400425
GCC_PRECOMPILE_PREFIX_HEADER = YES;
401426
GCC_PREFIX_HEADER = TiImagefactory_Prefix.pch;
402427
GCC_PREPROCESSOR_DEFINITIONS = "TI_VERSION=$(TI_VERSION)";
403428
GCC_THUMB_SUPPORT = NO;
404429
GCC_TREAT_WARNINGS_AS_ERRORS = NO;
405430
GCC_VERSION = "";
431+
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
406432
GCC_WARN_ABOUT_RETURN_TYPE = NO;
407433
GCC_WARN_MISSING_PARENTHESES = NO;
408434
GCC_WARN_SHADOW = NO;
409435
GCC_WARN_STRICT_SELECTOR_MATCH = NO;
436+
GCC_WARN_UNDECLARED_SELECTOR = YES;
437+
GCC_WARN_UNINITIALIZED_AUTOS = YES;
410438
GCC_WARN_UNUSED_FUNCTION = YES;
411439
GCC_WARN_UNUSED_PARAMETER = NO;
412440
GCC_WARN_UNUSED_VALUE = NO;

ios/titanium.xcconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// OF YOUR TITANIUM SDK YOU'RE BUILDING FOR
55
//
66
//
7-
TITANIUM_SDK_VERSION = 6.0.1.GA
7+
TITANIUM_SDK_VERSION = 6.0.4.GA
88

99

1010
//

0 commit comments

Comments
 (0)