Skip to content

Commit 50c06bc

Browse files
authored
Restore filtering of non-src files (#776)
* Restore filtering of non-src files This patch restores the filtering of non-src files that was lost in #767. After JuliaLang/julia#49866, `Base.parse_cache_header` returns both the non-filtered and filtered list instead of doing filtering internally based on the `srcfiles_only::Bool` keyword argument. There is a test for this failure mode that fails on Revise master branch and passes with this patch (see https://github.com/timholy/Revise.jl/blob/1059181bed06387e9fbcea137dce28a80c5c45d9/test/runtests.jl#L3070-L3080). * Set version to 3.5.9.
1 parent 1059181 commit 50c06bc

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "Revise"
22
uuid = "295af30f-e4ad-537b-8983-00126c2a3abe"
3-
version = "3.5.8"
3+
version = "3.5.9"
44

55
[deps]
66
CodeTracking = "da1fd8a2-8d9e-5ec2-8556-3022fb5608a2"

src/loading.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ function pkg_fileinfo(id::PkgId)
44
cachepath = origin.cachepath
55
cachepath === nothing && return nothing, nothing, nothing
66
provides, includes_requires, required_modules = try
7-
@static if VERSION v"1.11.0-DEV.683"
8-
Base.parse_cache_header(cachepath)
7+
@static if VERSION v"1.11.0-DEV.683" # https://github.com/JuliaLang/julia/pull/49866
8+
provides, (_, includes_srcfiles_only, requires), required_modules, _... =
9+
Base.parse_cache_header(cachepath)
10+
provides, (includes_srcfiles_only, requires), required_modules
911
else
1012
Base.parse_cache_header(cachepath, srcfiles_only = true)
1113
end

0 commit comments

Comments
 (0)