Added client_secret and refresh token function#90
Conversation
|
@timo-reymann thanks for this lib, helped me simplify a little command line utility for myself that other libraries were making way to complicated. I've put through a small PR to add the ability to specify the client secret and obtain a new grant with the refresh token as I needed these for my project. Not sure if I've doen the PR correctly as it's my first one I've ever submitted so let me know if there's something eles I need to do. |
timo-reymann
left a comment
There was a problem hiding this comment.
Thank you so much for your PR, I just have some smaller comments mostly for keeping backward compability :)
(I use https://conventionalcomments.org/ for writing the review comments)
Co-authored-by: Timo Reymann <mail@timo-reymann.de>
Co-authored-by: Timo Reymann <mail@timo-reymann.de>
Co-authored-by: Timo Reymann <mail@timo-reymann.de>
Co-authored-by: Timo Reymann <mail@timo-reymann.de>
|
|
@timo-reymann implemented those suggestions and added the new test (plus one extra). I was getting port conflicts so implemented random port selection for testing but now getting security warnings. Probably not a real risk but will leave it up to you to decide 😄 Couldn't completely remove the client_secret from the tests as it complained about missing params in the constructor. I'm guessing it's a default constructor based of the class members (?) but without defining an explicit constructor I wasn;t sure how to fix. I figured setting it to None had the same effect? |
|
Thanks a lot 🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

Description