Commit 4c210d0
committed
Fix testunit CI hang by requiring test-unit >= 3.7.4
The 3.3 testunit CI job was hanging for 6 hours and timing out.
Problem:
test-unit 3.7.4 changed the TestSuite#run method signature:
- 3.7.3: run(result, run_context: nil, &block)
- 3.7.4+: run(worker_context, &block)
test-queue's TestSuite subclass uses `def run(*); super; end`, which
fails on 3.7.3 when test-unit internally calls run with 2 arguments:
ArgumentError: wrong number of arguments (given 2, expected 1)
The worker process crashes, but the master process keeps waiting
indefinitely, causing the hang.
Reproduction:
Hangs (with test-unit 3.7.3):
gem install test-unit -v 3.7.3
BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb
Works (with test-unit >= 3.7.4):
gem install test-unit -v 3.7.5
BUNDLE_GEMFILE=gemfiles/testunit.gemfile bundle exec testunit-queue ./test/examples/*_testunit.rb
Solution:
Pin test-unit to >= 3.7.4 in gemfiles/testunit.gemfile.1 parent e1674e1 commit 4c210d0
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
0 commit comments