Skip to content

Commit 75fc70e

Browse files
l1krafaeljw
authored andcommitted
ACPI / property: Don't evaluate objects for devices w/o handle
Fabricated devices such as LNXPWRBN lack a handle, causing evaluation of _CCA and _DSD to always fail with AE_BAD_PARAMETER. While that is merely a (negligible) waste of processing power, evaluating a _DSM for them (such as Apple's device properties _DSM which we're about to add) results in an ugly error: ACPI: \: failed to evaluate _DSM (0x1001) Avoid by not evaluating _DSD and the upcoming _DSM for devices without handle. Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 630b3af commit 75fc70e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/acpi/property.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,9 @@ void acpi_init_properties(struct acpi_device *adev)
339339

340340
INIT_LIST_HEAD(&adev->data.subnodes);
341341

342+
if (!adev->handle)
343+
return;
344+
342345
/*
343346
* Check if ACPI_DT_NAMESPACE_HID is present and inthat case we fill in
344347
* Device Tree compatible properties for this device.

0 commit comments

Comments
 (0)