trivial interpreters py touchups and test coverage improvements

[jurko-gospodnetic]

Trivial interpreters py touchups and test coverage improvements.

[codecov]

Codecov Report

Merging #708 into master will increase coverage by 0.57%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   93.95%   94.53%   +0.57%     
==========================================
  Files          11       11              
  Lines        2416     2414       -2     
==========================================
+ Hits         2270     2282      +12     
+ Misses        146      132      -14

Impacted Files	Coverage Δ
tox/interpreters.py	92.85% <50%> (+10.82%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060758d...b9dd974. Read the comment docs.

[gaborbernat]

hi, the lint fix failed 👍

[jurko-gospodnetic]

doh... I hate that 'reorder imports' failure... wish it would tell me what it wants them to be reordered to...

Could it be updated to print out the order it wants in its error output?

I really have to get fix-lint to run on my machine...

[gaborbernat]

@asottile I feel the same as @jurko-gospodnetic the pre-commit often gives fairly cryptic errors; also i would prefer to group together imports (instead one per line)

[jurko-gospodnetic]

Ok, somehow hacked together fix-lint to work on my machine (that whole thing is totally unfriendly to my setup... 😞) and finally found the culprit reordering... seems the ordering it wants is case-sensitive :-)

[asottile]

The brevity of the error messages is intentional. The general guidance is : if it gets automatically fixed there's no need to spam a bunch of text, the filename is sufficient. But as it's apparent that you're not running them locally, I'm adding this so you can at least see the diff : #710

As for the imports: it's impossible to agree on style when there are this many maintainers so we opted for a style that eliminates merge conflicts. If you're unhappy with this let's create an issue and discuss the trade offs of removing the import ordering entirely -- though I imagine this will just make things worse ;)

[gaborbernat]

@asottile it does eliminate the probability of merge conflict, but increases the number of lines 👍 I'm not for removing it, just tweaking it. I would prefer to have something that works out of box, e.g. @jurko-gospodnetic struggle to get the fix-lint working is definitely what I was afraid of.

[gaborbernat]

Thanks for the contribution @jurko-gospodnetic 👍