Change make_credential() to return credential_id instead of true

This allows a caller to store the new credential_id together with e.g. a user_id for the user.

Author: joelonsql

FUNCTIONS/make_credential.sql

@@ -1,5 +1,5 @@
 CREATE OR REPLACE FUNCTION webauthn.make_credential(username text, challenge text, credential_raw_id text, credential_type text, attestation_object text, client_data_json text, relaying_party text)
-RETURNS boolean
+RETURNS bigint
 LANGUAGE sql
 AS $$
 WITH
@@ -21,5 +21,5 @@ SELECT
   decode(attestation_object,'base64'),
   decode(client_data_json,'base64')
 FROM consume_challenge
-RETURNING TRUE
+RETURNING credential_id
 $$;

README.md

@@ -114,12 +114,12 @@ curl 'http://localhost/api/rpc/init_credential' \
 }
 ```
 
-<h3 id="make-credential"><code>webauthn.make_credential(username text, challenge base64, credential_raw_id base64, credential_type text, attestation_object base64, client_data_json base64, relaying_party text) RETURNS boolean</code></h3>
+<h3 id="make-credential"><code>webauthn.make_credential(username text, challenge base64, credential_raw_id base64, credential_type text, attestation_object base64, client_data_json base64, relaying_party text) RETURNS bigint</code></h3>
 
 Stores the public key for the credential generated by the browser to the [webauthn.credentials](https://github.com/truthly/pg-webauthn/blob/master/TABLES/credentials.sql) table.
 The function also verifies there is an unconsumed matching `challenge` for the given `username`,
 which is consumed in the same transaction as the credential is stored.
-Returns `true` if successful.
+Returns `credential_id` of type `bigint` if successful.
 
 Via `psql` prompt:
 
@@ -144,7 +144,7 @@ curl 'http://localhost/api/rpc/make_credential' \
 ```
 
 ```json
-true
+1
 ```
 
 <h3 id="sign-in">5.2. Sign-in functions</h3>

expected/invalid_base64.out

@@ -54,7 +54,7 @@ SELECT make_credential(
 );
  make_credential 
 -----------------
- t
+               1
 (1 row)
 
 -- Replace random challenge with null to make test output predictable

expected/invalid_signature.out

@@ -54,7 +54,7 @@ SELECT make_credential(
 );
  make_credential 
 -----------------
- t
+               1
 (1 row)
 
 -- Replace random challenge with null to make test output predictable

expected/valid_signature.out

@@ -54,7 +54,7 @@ SELECT make_credential(
 );
  make_credential 
 -----------------
- t
+               1
 (1 row)
 
 -- Replace random challenge with null to make test output predictable