More C coverage

Author: nspope

c/tests/test_stats.c

@@ -533,6 +533,7 @@ verify_pair_coalescence_rates(tsk_treeseq_t *ts)
     tsk_size_t sample_set_sizes[P];
     tsk_id_t index_tuples[2 * I];
     tsk_id_t node_bin_map[N];
+    tsk_id_t empty_node_bin_map[N];
     tsk_size_t dim = T * B * I;
     double C[dim];
     tsk_size_t i, j, k;
@@ -544,6 +545,7 @@ verify_pair_coalescence_rates(tsk_treeseq_t *ts)
                 node_bin_map[i] = (tsk_id_t) j;
             }
         }
+        empty_node_bin_map[i] = TSK_NULL;
     }
 
     for (i = 0; i < n; i++) {
@@ -568,13 +570,17 @@ verify_pair_coalescence_rates(tsk_treeseq_t *ts)
     ret = tsk_treeseq_pair_coalescence_rates(ts, P, sample_set_sizes, sample_sets, I,
         index_tuples, T, breakpoints, B, node_bin_map, epochs, 0, C);
     CU_ASSERT_EQUAL_FATAL(ret, 0);
+    /* TODO: compare against naive coalescence rates per tree */
 
     node_bin_map[0] = TSK_NULL;
     ret = tsk_treeseq_pair_coalescence_rates(ts, P, sample_set_sizes, sample_sets, I,
         index_tuples, T, breakpoints, B, node_bin_map, epochs, 0, C);
     CU_ASSERT_EQUAL_FATAL(ret, 0);
     node_bin_map[0] = 0;
-    /* TODO: compare against naive coalescence rates per tree */
+
+    ret = tsk_treeseq_pair_coalescence_rates(ts, P, sample_set_sizes, sample_sets, I,
+        index_tuples, T, breakpoints, B, empty_node_bin_map, epochs, 0, C);
+    CU_ASSERT_EQUAL_FATAL(ret, 0);
 
     /* cover errors */
     ret = tsk_treeseq_pair_coalescence_rates(ts, P, sample_set_sizes, sample_sets, I,

c/tskit/trees.c

@@ -9256,7 +9256,7 @@ pair_coalescence_quantiles(tsk_size_t input_dim, const double *weight,
     j = 0;
     coalesced = 0.0;
     timepoint = -INFINITY;
-    /* TODO: binary search might be better */
+    /* TODO: may be more efficient to use a binary search */
     for (i = 0; i < input_dim; i++) {
         if (weight[i] > 0) {
             coalesced += weight[i];