Fix jsonschema validators error#2844
Merged
benjeffery merged 2 commits intotskit-dev:mainfrom Oct 4, 2023
Merged
Conversation
Member
Author
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
jeromekelleher
approved these changes
Oct 4, 2023
benjeffery
force-pushed
the
fix-jsonschema-2
branch
from
3515aa7 to
8b03221
Compare
Codecov Report
@@ Coverage Diff @@
## main #2844 +/- ##
==========================================
- Coverage 90.58% 89.76% -0.82%
==========================================
Files 26 30 +4
Lines 21413 29898 +8485
Branches 4313 5803 +1490
==========================================
+ Hits 19396 26838 +7442
- Misses 1124 1753 +629
- Partials 893 1307 +414
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2840
A change in jsonschema 4.19.0 has moved the location of functions that we were using. This patch means both old and new versions will work.