Lowlevel pair coalescence quantiles#2976
Merged
mergify[bot] merged 1 commit intotskit-dev:mainfrom Aug 28, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
==========================================
+ Coverage 89.66% 89.72% +0.05%
==========================================
Files 29 29
Lines 30435 30609 +174
Branches 5905 5938 +33
==========================================
+ Hits 27290 27464 +174
Misses 1799 1799
Partials 1346 1346
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
This is ready for a look @jeromekelleher |
nspope
force-pushed
the
pair-coalescence-quantiles
branch
from
cc507c0 to
8c4d3d3
Compare
jeromekelleher
approved these changes
Aug 27, 2024
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM! Happy to merge when you are.
nspope
force-pushed
the
pair-coalescence-quantiles
branch
from
8c4d3d3 to
b551a95
Compare
Contributor
Author
|
Great, let's get it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C implementation of
pair_coalescence_quantiles