Merged
Conversation
jeromekelleher
approved these changes
Oct 16, 2024
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Great, thanks @hyanwong
Member
|
Can you add rf_distance to the CHANGELOG while you're here? Crediting Ao |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 11 11
Lines 24666 24666
Branches 4556 4556
=======================================
Hits 21478 21478
Misses 1824 1824
Partials 1364 1364
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Member
Author
|
Changelog added. Let's get this baby shipped @benjeffery ! |
Member
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the first commit in the PR, I have moved all the
kc_distancetesting fromtest_topology.pyinto the newtest_distance_metrics.pyfile, created by @Billyzhang1229 for the rf tests. This seems more logical, and usefully slims down the hugetest_topology.pyfile. At some point we might want to rationalise that file though, as thekc_testing and therf_testing take rather different approaches.