import xml.dom.minidom; closes #3144#3145
Merged
mergify[bot] merged 1 commit intotskit-dev:mainfrom Apr 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
==========================================
- Coverage 89.94% 89.72% -0.23%
==========================================
Files 29 29
Lines 32651 32225 -426
Branches 5854 5890 +36
==========================================
- Hits 29368 28913 -455
- Misses 1869 1882 +13
- Partials 1414 1430 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
benjeffery
approved these changes
Apr 27, 2025
Member
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
Thanks for this @petrelharp - will see if the tests can be fixed separately.
| **Bugfixes** | ||
|
|
||
| - Meatdata.schema was returning a modified schema, this is fixed to return a copy of | ||
| - Metadata.schema was returning a modified schema, this is fixed to return a copy of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix (but, I don't know how to change the tests to have caught this...)