Skip to content

Commit 46b918b

Browse files
authored
Merge pull request #195 from tv2-oss/feature/chart-add-json-log-support
Add json log support to helm chart
2 parents 2787576 + 02f47af commit 46b918b

File tree

5 files changed

+28
-1
lines changed

5 files changed

+28
-1
lines changed

charts/bifrost-gateway-controller/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
## [UNRELEASED]
44

55
- Example text, add your PR info according to example below below this line. Do not bump chart version in Chart.yaml.
6-
- chart image tag default to Chart.appVersion instead of latest. ([#194](https://github.com/tv2-oss/bifrost-gateway-controller/pull/194)) [@michaelvl](https://github.com/michaelvl)
6+
- Add json log support to helm chart ([#195](https://github.com/tv2-oss/bifrost-gateway-controller/pull/195)) [@michaelvl](https://github.com/michaelvl)
7+
- Chart image tag default to Chart.appVersion instead of latest. ([#194](https://github.com/tv2-oss/bifrost-gateway-controller/pull/194)) [@michaelvl](https://github.com/michaelvl)
78

89
## [0.1.7]
910

charts/bifrost-gateway-controller/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ Gateway API driven management of network infrastructure across Kubernetes and cl
1818
| controllerManager.manager.livenessProbe.httpGet.port | int | `8081` | |
1919
| controllerManager.manager.livenessProbe.initialDelaySeconds | int | `15` | |
2020
| controllerManager.manager.livenessProbe.periodSeconds | int | `20` | |
21+
| controllerManager.manager.logging.format | string | `"json"` | Logging format. Defaults to text |
22+
| controllerManager.manager.logging.level | string | `"debug"` | Log level [debug|info|error] |
2123
| controllerManager.manager.rbac.additionalPermissions | list | `[]` | |
2224
| controllerManager.manager.readinessProbe.httpGet.path | string | `"/readyz"` | |
2325
| controllerManager.manager.readinessProbe.httpGet.port | int | `8081` | |

charts/bifrost-gateway-controller/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ spec:
3030
containers:
3131
- args:
3232
- --leader-elect
33+
- --zap-log-level={{ .Values.controllerManager.manager.logging.level }}
34+
{{ if eq .Values.controllerManager.manager.logging.format "json" -}}
35+
- --zap-devel=false
36+
{{- end }}
3337
command:
3438
- /bifrost-gateway-controller
3539
{{- if (contains "sha256:" .Values.controllerManager.manager.image.tag) }}

charts/bifrost-gateway-controller/values.schema.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,20 @@
5050
"livenessProbe": {
5151
"type": "object"
5252
},
53+
"logging": {
54+
"required": [
55+
"format",
56+
"level"
57+
],
58+
"properties": {
59+
"format": {
60+
"type": "string"
61+
},
62+
"level": {
63+
"type": "string"
64+
}
65+
}
66+
},
5367
"readinessProbe": {
5468
"type": "object"
5569
},

charts/bifrost-gateway-controller/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ controllerManager:
1919
cpu: 10m
2020
memory: 64Mi
2121

22+
logging:
23+
# -- Logging format. Defaults to text
24+
format: json
25+
# -- Log level [debug|info|error]
26+
level: debug
27+
2228
livenessProbe:
2329
httpGet:
2430
path: /healthz

0 commit comments

Comments
 (0)