Skip to content

Always toggle the dropdowns when clicking on the toggle trigger #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foca wants to merge 1 commit into from
Closed

Always toggle the dropdowns when clicking on the toggle trigger #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions js/bootstrap-dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@

$parent.length || ($parent = $this.parent())

clearMenus()

!$parent.hasClass('open') && $parent.toggleClass('open')
$parent.toggleClass('open')
Copy link
Copy Markdown
Member

@fat fat Jan 3, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Copy Markdown
Author

@foca foca Jan 3, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, now that you ask… I was only trying with a single drop down menu,
so I never noticed why that was there.

However, without removing that it won't hide the drop down when you
click on it while open. I'll look into it further tomorrow.

Cheers,

2012/1/2 Jacob Thornton
reply@reply.github.com:

@@ -41,9 +41,7 @@

       $parent.length || ($parent = $this.parent())

  •      clearMenus()

why remove this?

Reply to this email directly or view it on GitHub:
https://github.com/twitter/bootstrap/pull/874/files#r322803


return false
}
Expand Down