This repository was archived by the owner on May 4, 2022. It is now read-only.
Remove phantom js runner from Karma#653
Merged
ChristianMurphy merged 1 commit intouPortal-Attic:masterfrom Jun 30, 2017
ChristianMurphy:NOJIRA-remove-phantom-and-phantom-launcher
Merged
Remove phantom js runner from Karma#653ChristianMurphy merged 1 commit intouPortal-Attic:masterfrom ChristianMurphy:NOJIRA-remove-phantom-and-phantom-launcher
ChristianMurphy merged 1 commit intouPortal-Attic:masterfrom
ChristianMurphy:NOJIRA-remove-phantom-and-phantom-launcher
Conversation
vertein
approved these changes
Jun 30, 2017
Contributor
|
What's the real security risk with phantomjs? Considering it is only used within the testing, and all code that calls it is our own, I'd think those risks are mitigated. That said, I have no opinion over which launcher we use. |
davidmsibley
approved these changes
Jun 30, 2017
apetro
approved these changes
Jun 30, 2017
Contributor
|
Hurray for removing dependencies we don't need. Let's worry about the realities of phantomjs security if and when there's a need for it to come back in as a dependency. :) |
Contributor
Author
|
@davidmsibley uPortal-Attic/uportal-app-framework#462 gives more in-depth explanation for the switch. 📜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome is now primary test runner.
Also https://www.bithound.io/github/ChristianMurphy/angularjs-portal/master/dependencies/npm/phantomjs#security-advisories
Contributor License Agreement adherence: