Skip to content

Commit 39632b5

Browse files
committed
feat(docs): tweak docs
1 parent affb746 commit 39632b5

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ RUN mkdir -p "$GOPATH/src" "$GOPATH/bin" && chmod -R 777 "$GOPATH"
4040

4141
WORKDIR /app/secret-agent
4242

43+
# NOTE: You must run yarn build:docker from root for this to work
4344
COPY ./build-dist /app/secret-agent/
4445

4546
RUN cat /etc/*-release

website/docs/BasicInterfaces/FrameEnvironment.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ NOTE: this method should NOT be called in a Frame Document that has no visible e
236236

237237
#### **Returns**: `Promise<void>`
238238

239-
### frameEnvironment.waitForElement*(element)* {#wait-for-element}
239+
### frameEnvironment.waitForElement*(element, options)* {#wait-for-element}
240240

241241
Wait until a specific element is present in the dom.
242242

@@ -284,6 +284,7 @@ The following are possible statuses and their meanings:
284284
| `HttpResponded` | The http response has been retrieved |
285285
| `HttpRedirected` | The original http request was redirected |
286286
| `DomContentLoaded` | The dom content has been received and loaded into the document |
287+
| `AllContentLoaded` | The page load event has triggered. NOTE: this does not ALWAYS trigger in browser. |
287288
| `PaintingStable` | The page has loaded the main content above the fold. Works on javascript-rendered pages. |
288289

289290
### frameEnvironment.waitForLocation*(trigger, options)* {#wait-for-location}

website/docs/BasicInterfaces/Tab.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ Takes a screenshot of the current contents rendered in the browser.
270270

271271
#### **Returns**: `Promise<Buffer>` Buffer with image bytes in base64.
272272

273-
### tab.waitForElement*(element)* {#wait-for-element}
273+
### tab.waitForElement*(element, options)* {#wait-for-element}
274274

275275
Wait until a specific element is present in the dom of the [mainFrameEnvironment](#main-frame-environment).
276276

@@ -348,6 +348,7 @@ The following are possible statuses and their meanings:
348348
| `HttpResponded` | The http response has been retrieved |
349349
| `HttpRedirected` | The original http request was redirected |
350350
| `DomContentLoaded` | The dom content has been received and loaded into the document |
351+
| `AllContentLoaded` | The page load event has triggered. NOTE: this does not ALWAYS trigger in browser. |
351352
| `PaintingStable` | The page has loaded the main content above the fold. Works on javascript-rendered pages. |
352353

353354
### tab.waitForLocation*(trigger, options)* {#wait-for-location}

0 commit comments

Comments
 (0)