fix(core): only reject navigation with errors

closes #153

Author: blakebyrnes

.eslintrc.js

@@ -31,6 +31,9 @@ module.exports = {
     'prettier',
     'prettier/@typescript-eslint',
     'plugin:monorepo-cop/recommended',
+    'plugin:import/errors',
+    'plugin:import/warnings',
+    'plugin:import/typescript',
   ],
   plugins: ['monorepo-cop'],
   parserOptions: {
@@ -40,6 +43,11 @@ module.exports = {
   settings: {
     'import/core-modules': ['electron'],
     'import/external-module-folders': workspacesWithModules,
+    'import/resolver': {
+      typescript: {
+        project: ['tsconfig.json', 'replay/tsconfig.json', 'replay/frontend/tsconfig.json'],
+      },
+    },
   },
   env: {
     node: true,

copyfiles.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
+// eslint-disable-next-line import/no-extraneous-dependencies,import/no-self-import
 const copyfiles = require('copyfiles');
 const Fs = require('fs');
 const pkg = require('./package.json');

core-interfaces/ResourceType.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 import Protocol from 'devtools-protocol';
 import Network = Protocol.Network;
 import DevtoolsResourceType = Network.ResourceType;

core/lib/Tab.ts

@@ -690,13 +690,6 @@ b) Use the UserProfile feature to set cookies for 1 or more domains before they'
         'Resource failed to load, but the reason was not provided by devtools.',
       );
     }
-    if (
-      resource.resourceType === 'Document' &&
-      resource.browserRequestId === this.navigations.top?.browserRequestId &&
-      this.navigations?.top?.resourceId?.isResolved === false
-    ) {
-      this.navigations.top.navigationError = loadError;
-    }
 
     this.session.mitmRequestSession.browserRequestFailed({
       resource,
@@ -706,6 +699,7 @@ b) Use the UserProfile feature to set cookies for 1 or more domains before they'
 
     const resources = this.sessionState.getBrowserRequestResources(event.resource.browserRequestId);
     if (resources?.length) {
+      // this function will resolve any pending resourceId for a navigation
       this.sessionState.captureResourceError(
         this.id,
         MitmRequestContext.toEmittedResource({ id: resources[0].resourceId, ...resource } as any),

core/lib/TabNavigations.ts

@@ -136,11 +136,11 @@ export default class TabNavigations extends TypedEventEmitter<TabNavigationEvent
       currentUrl: this.currentUrl,
     });
     if (!this.top || this.top.resourceId.isResolved) return;
-    if (statusCode >= 400 || error) {
-      // since we don't know if there are listeners yet, we need to just set the error on the return value
-      // otherwise, get unhandledrejections
-      this.top.navigationError = error ?? new Error('Failed to load url');
-    }
+
+    // since we don't know if there are listeners yet, we need to just set the error on the return value
+    // otherwise, get unhandledrejections
+    if (error) this.top.navigationError = error;
+
     this.top.resourceId.resolve(resourceId);
   }
 

package.json

@@ -53,15 +53,16 @@
     "eslint": "^7.14.0",
     "eslint-config-airbnb-typescript": "^12.0.0",
     "eslint-config-prettier": "^6.15.0",
-    "eslint-plugin-monorepo-cop": "^1.0.2",
+    "eslint-import-resolver-typescript": "^2.3.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^24.1.3",
-    "eslint-plugin-react": "^7.21.5",
-    "eslint-plugin-react-hooks": "^4.2.0",
     "eslint-plugin-jsx-a11y": "^6.4.1",
+    "eslint-plugin-monorepo-cop": "^1.0.2",
     "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-react": "^7.21.5",
+    "eslint-plugin-react-hooks": "^4.2.0",
     "husky": "^4.3.0",
     "jest": "^26.6.3",
     "jest-environment-node": "^26.6.2",

puppet/lib/BrowserFetcher.ts

@@ -23,7 +23,7 @@ import * as https from 'https';
 import * as http from 'http';
 
 import * as extractZip from 'extract-zip';
-import removeRecursive from 'rimraf';
+import * as removeRecursive from 'rimraf';
 import * as URL from 'url';
 import { HttpsProxyAgent, HttpsProxyAgentOptions } from 'https-proxy-agent';
 import { getProxyForUrl } from 'proxy-from-env';

puppet/lib/EngineInstaller.ts

@@ -1,7 +1,7 @@
 import * as os from 'os';
-import ProgressBar from 'progress';
+import * as ProgressBar from 'progress';
 import { BrowserFetcher } from './BrowserFetcher';
-import { getInstallDirectory } from "./browserPaths";
+import { getInstallDirectory } from './browserPaths';
 
 export default class EngineInstaller {
   constructor(readonly engine: { browser: string; revision: string }) {}

yarn.lock

@@ -7860,6 +7860,17 @@ eslint-import-resolver-node@^0.3.4:
     debug "^2.6.9"
     resolve "^1.13.1"
 
+eslint-import-resolver-typescript@^2.3.0:
+  version "2.3.0"
+  resolved "https://registry.yarnpkg.com/eslint-import-resolver-typescript/-/eslint-import-resolver-typescript-2.3.0.tgz#0870988098bc6c6419c87705e6b42bee89425445"
+  integrity sha512-MHSXvmj5e0SGOOBhBbt7C+fWj1bJbtSYFAD85Xeg8nvUtuooTod2HQb8bfhE9f5QyyNxEfgzqOYFCvmdDIcCuw==
+  dependencies:
+    debug "^4.1.1"
+    glob "^7.1.6"
+    is-glob "^4.0.1"
+    resolve "^1.17.0"
+    tsconfig-paths "^3.9.0"
+
 eslint-module-utils@^2.6.0:
   version "2.6.0"
   resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.6.0.tgz#579ebd094f56af7797d19c9866c9c9486629bfa6"
@@ -9286,7 +9297,7 @@ glob-to-regexp@^0.3.0:
   resolved "https://registry.yarnpkg.com/glob-to-regexp/-/glob-to-regexp-0.3.0.tgz#8c5a1494d2066c570cc3bfe4496175acc4d502ab"
   integrity sha1-jFoUlNIGbFcMw7/kSWF1rMTVAqs=
 
-glob@^7.0.0, glob@^7.0.3, glob@^7.0.5, glob@^7.1.1, glob@^7.1.2, glob@^7.1.3, glob@^7.1.4, glob@~7.1.1:
+glob@^7.0.0, glob@^7.0.3, glob@^7.0.5, glob@^7.1.1, glob@^7.1.2, glob@^7.1.3, glob@^7.1.4, glob@^7.1.6, glob@~7.1.1:
   version "7.1.6"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.6.tgz#141f33b81a7c2492e125594307480c46679278a6"
   integrity sha512-LwaxwyZ72Lk7vZINtNNrywX0ZuLyStrdDtabefZKAY5ZGJhVtgdznluResxNmPitE0SAO+O26sWTHeKSI2wMBA==