fix: some tests were failing

Author: calebjclark

emulate-browsers/base/test/plugins-Chrome.json

@@ -60,6 +60,8 @@
     },
     "_$function": "function MimeType() { [native code] }",
     "_$type": "function",
+    "_$invocation": "TypeError: Illegal constructor",
+    "_$value": "function MimeType() { [native code] }",
     "_$flags": "cw"
   },
   "MimeTypeArray": {
@@ -140,6 +142,8 @@
     },
     "_$function": "function MimeTypeArray() { [native code] }",
     "_$type": "function",
+    "_$invocation": "TypeError: Illegal constructor",
+    "_$value": "function MimeTypeArray() { [native code] }",
     "_$flags": "cw"
   },
   "Plugin": {
@@ -202,6 +206,7 @@
         },
         "_$function": "function item() { [native code] }",
         "_$invocation": "TypeError: Illegal invocation",
+        "_$value": "function item() { [native code] }",
         "_$type": "function",
         "_$flags": "cew"
       },
@@ -218,6 +223,7 @@
         },
         "_$function": "function namedItem() { [native code] }",
         "_$invocation": "TypeError: Illegal invocation",
+        "_$value": "function namedItem() { [native code] }",
         "_$type": "function",
         "_$flags": "cew"
       },
@@ -235,7 +241,9 @@
       "_$type": "constructor"
     },
     "_$function": "function Plugin() { [native code] }",
+    "_$invocation": "TypeError: Illegal constructor",
     "_$type": "function",
+    "_$value": "function Plugin() { [native code] }",
     "_$flags": "cw"
   },
   "PluginArray": {
@@ -280,6 +288,7 @@
         },
         "_$function": "function item() { [native code] }",
         "_$invocation": "TypeError: Illegal invocation",
+        "_$value": "function item() { [native code] }",
         "_$type": "function",
         "_$flags": "cew"
       },
@@ -296,6 +305,7 @@
         },
         "_$function": "function namedItem() { [native code] }",
         "_$invocation": "TypeError: Illegal invocation",
+        "_$value": "function namedItem() { [native code] }",
         "_$type": "function",
         "_$flags": "cew"
       },
@@ -312,6 +322,7 @@
         },
         "_$function": "function refresh() { [native code] }",
         "_$invocation": "TypeError: Illegal invocation",
+        "_$value": "function refresh() { [native code] }",
         "_$type": "function",
         "_$flags": "cew"
       },
@@ -330,7 +341,7 @@
     },
     "_$function": "function PluginArray() { [native code] }",
     "_$invocation": "TypeError: Illegal constructor",
-    "_$value": "function Plugin() { [native code] }",
+    "_$value": "function PluginArray() { [native code] }",
     "_$type": "function",
     "_$flags": "cw"
   }

emulate-browsers/base/test/plugins.test.ts

@@ -136,6 +136,7 @@ test('it should override plugins in a browser window', async () => {
       false,
     )) as any,
   ).window;
+
   for (const proto of ['Plugin', 'PluginArray', 'MimeType', 'MimeTypeArray']) {
     if (debug) console.log(proto, inspect(structure[proto], false, null, true));
     expect(structure[proto]).toStrictEqual(pluginsChrome[proto]);

replay/index.ts

@@ -9,7 +9,6 @@ import {
   isBinaryInstalled,
   isLocalBuildPresent,
 } from './install/Utils';
-import getResolvable from '~shared/utils/promise';
 
 const replayDir = getInstallDirectory();
 const registrationApiFilepath = `${replayDir}/api.txt`;
@@ -125,22 +124,26 @@ export async function openReplayApp(...extraArgs: string[]) {
     child = await launchReplay(getBinaryPath(), ['--binary-launch', ...extraArgs]);
   }
 
-  const registrationComplete = getResolvable<void>();
+  let registrationResolve: () => any;
+  let registrationReject: (reason?: any) => any;
+  const registrationComplete = new Promise<void>((resolve, reject) => {
+    registrationResolve = resolve;
+    registrationReject = reject;
+  });
   const onPrematureExit = (code, signal) =>
-    registrationComplete.reject(new Error(`Replay shutdown with exit code ${code}: ${signal}`));
+    registrationReject(new Error(`Replay shutdown with exit code ${code}: ${signal}`));
   child.once('exit', onPrematureExit);
-  child.once('error', registrationComplete.reject);
-
+  child.once('error', registrationReject);
   // wait for change
   const watcher = Fs.watch(registrationApiFilepath, { persistent: false, recursive: false }, () => {
     if (resolveHost()) {
-      registrationComplete.resolve();
+      registrationResolve();
     }
   });
-  return registrationComplete.promise.finally(() => {
+  return registrationComplete.finally(() => {
     watcher.close();
     child.off('exit', onPrematureExit);
-    child.off('error', registrationComplete.reject);
+    child.off('error', registrationReject);
   });
 }