fix(logger): don’t use colors if disalbed in node

fix(connection): only serialize known props

Author: blakebyrnes

client/connections/ConnectionToCore.ts

@@ -7,6 +7,7 @@ import Log from '@secret-agent/commons/Logger';
 import ICreateSessionOptions from '@secret-agent/core-interfaces/ICreateSessionOptions';
 import ISessionMeta from '@secret-agent/core-interfaces/ISessionMeta';
 import { CanceledPromiseError } from '@secret-agent/commons/interfaces/IPendingWaitEvent';
+import ICoreConfigureOptions from '@secret-agent/core-interfaces/ICoreConfigureOptions';
 import IConnectionToCoreOptions from '../interfaces/IConnectionToCoreOptions';
 import CoreCommandQueue from '../lib/CoreCommandQueue';
 import CoreSession from '../lib/CoreSession';
@@ -60,7 +61,14 @@ export default abstract class ConnectionToCore {
         if (err) throw err;
         return this.internalSendRequestAndWait({
           command: 'connect',
-          args: [this.options],
+          args: [
+            <ICoreConfigureOptions>{
+              coreServerPort: this.options.coreServerPort,
+              browserEmulatorIds: this.options.browserEmulatorIds,
+              localProxyPortStart: this.options.localProxyPortStart,
+              sessionsDir: this.options.sessionsDir,
+            },
+          ],
         });
       })
       .then(result => this.onConnected(result.data))

commons/Logger.ts

@@ -96,12 +96,13 @@ class Log implements ILog {
 
       const params = Object.keys(printData).length ? [printData] : [];
       if (error) params.push(error);
+      const useColors = process.env.NODE_DISABLE_COLORS !== 'true';
       // eslint-disable-next-line no-console
       console.log(
         `${entry.timestamp.toISOString()} ${entry.level.toUpperCase()} [${printablePath}] ${
           entry.action
         }`,
-        ...params.map(x => inspect(x, false, null, true)),
+        ...params.map(x => inspect(x, false, null, useColors)),
       );
     }
     LogEvents.broadcast(entry);