fix(core): convert dates to numbers

Author: blakebyrnes

client/lib/ResourceRequest.ts

@@ -32,8 +32,8 @@ export default class ResourceRequest {
     return getRequestProperty(this, 'url');
   }
 
-  public get timestamp(): Promise<string> {
-    return getRequestProperty(this, 'timestamp');
+  public get timestamp(): Promise<Date> {
+    return getRequestProperty(this, 'timestamp').then(x => (x ? new Date(x as number) : null));
   }
 
   public get method(): Promise<string> {

client/lib/ResourceResponse.ts

@@ -47,8 +47,8 @@ export default class ResourceResponse {
     return getResponseProperty(this, 'url');
   }
 
-  public get timestamp(): Promise<string> {
-    return getResponseProperty(this, 'timestamp');
+  public get timestamp(): Promise<Date> {
+    return getResponseProperty(this, 'timestamp').then(x => (x ? new Date(x as number) : null));
   }
 
   public get remoteAddress(): Promise<string> {

client/lib/ScriptInstance.ts

@@ -8,7 +8,7 @@ const { log } = Log(module);
 export default class ScriptInstance {
   public readonly id: string = uuidv1();
   public readonly entrypoint: string = process.argv[1];
-  public readonly startDate: string = new Date().toISOString();
+  public readonly startDate = new Date().getTime();
   private sessionNameCountByName: { [name: string]: number } = {};
 
   public get meta(): IScriptInstanceMeta {

core-interfaces/GenericTypes.ts

@@ -1,2 +1,3 @@
 export type CommandId = number;
 export type ISOTimestamp = string;
+export type UnixTimestamp = number;

core-interfaces/ICommandMeta.ts

@@ -4,8 +4,8 @@ export default interface ICommandMeta {
   frameId: string;
   name: string;
   args?: string;
-  startDate: string;
-  endDate?: string;
+  startDate: number;
+  endDate?: number;
   result?: any;
   resultType?: string;
 }

core-interfaces/IDomChangeEvent.ts

@@ -1,13 +1,12 @@
 // tslint:disable-next-line
-import type { CommandId, ISOTimestamp } from './GenericTypes';
+import type { UnixTimestamp } from './GenericTypes';
 
 type Idx = number;
 
 export type IDomChangeEvent = [
-  CommandId,
   'newDocument' | 'location' | 'added' | 'removed' | 'text' | 'attribute' | 'property',
   INodeData,
-  ISOTimestamp,
+  UnixTimestamp,
   Idx,
 ];
 

core-interfaces/IFocusEvent.ts

@@ -1,8 +1,8 @@
 // tslint:disable-next-line
-import { CommandId, ISOTimestamp } from './GenericTypes';
+import { UnixTimestamp } from './GenericTypes';
 
 type NodeId = number;
 type RelatedNodeId = NodeId;
 type FocusEventType = 'in' | 'out';
 
-export type IFocusEvent = [CommandId, FocusEventType, NodeId, RelatedNodeId, ISOTimestamp];
+export type IFocusEvent = [FocusEventType, NodeId, RelatedNodeId, UnixTimestamp];

core-interfaces/ILoadEvent.ts

@@ -1,6 +1,6 @@
-import { CommandId, ISOTimestamp } from './GenericTypes';
+import { UnixTimestamp } from './GenericTypes';
 
 type EventName = string;
 type Url = string;
 
-export type ILoadEvent = [CommandId, EventName, Url, ISOTimestamp];
+export type ILoadEvent = [EventName, Url, UnixTimestamp];

core-interfaces/IMouseEvent.ts

@@ -1,5 +1,5 @@
 // tslint:disable-next-line
-import { CommandId, ISOTimestamp } from './GenericTypes';
+import { UnixTimestamp } from './GenericTypes';
 
 /**
  * Buttons are a bit field from the DOM
@@ -19,7 +19,6 @@ type RelatedNodeId = NodeId;
 type MouseEventType = number;
 
 export type IMouseEvent = [
-  CommandId,
   MouseEventType,
   PageX,
   PageY,
@@ -28,5 +27,5 @@ export type IMouseEvent = [
   Buttons,
   NodeId,
   RelatedNodeId,
-  ISOTimestamp,
+  UnixTimestamp,
 ];

core-interfaces/IResourceRequest.ts

@@ -2,7 +2,7 @@ import IResourceHeaders from './IResourceHeaders';
 
 export default interface IResourceRequest {
   url: string;
-  timestamp: string;
+  timestamp: number;
   headers: IResourceHeaders;
   trailers?: IResourceHeaders;
   method: string;