Skip to content

Commit 87d72ae

Browse files
committed
add TODO for ibc middleware acknowledgement
1 parent f0ecf0a commit 87d72ae

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

x/uibc/quota/ibc_module.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ func (im IBCMiddleware) OnRecvPacket(ctx sdk.Context, packet channeltypes.Packet
9393
func (im IBCMiddleware) OnAcknowledgementPacket(ctx sdk.Context, packet channeltypes.Packet, acknowledgement []byte,
9494
relayer sdk.AccAddress,
9595
) error {
96+
// TODO: recheck the ibc acknowledgement error handling
9697
var ack channeltypes.Acknowledgement
9798
if err := json.Unmarshal(acknowledgement, &ack); err != nil {
9899
return sdkerrors.ErrUnknownRequest.Wrapf("cannot unmarshal ICS-20 transfer packet acknowledgement: %v", err)

0 commit comments

Comments
 (0)