fix: skip BNB migration instead of error if no BNB denom present (#1825)

toteki · web-flow · commit c50033842099 · 2023-02-15T22:15:35.000Z
If the BNB denom is not present in the leverage registry, skips the BNB migration instead of causing an error.

This shouldn't affect mainnet or `canon-2`, but is good form in case we ever run this migration on a different testnet.
diff --git a/x/leverage/keeper/migrations.go b/x/leverage/keeper/migrations.go
@@ -29,7 +29,9 @@ func (m Migrator) MigrateBNB(ctx sdk.Context) (bool, error) {
 	}
 	token, err := m.keeper.GetTokenSettings(ctx, badDenom)
 	if err != nil {
-		return false, err
+		ctx.Logger().Error("leverage migration skipped due to missing token", "err", err.Error())
+		// If it's not a registered token, then we don't need to run this migration
+		return false, nil
 	}
 	// Delete previous entry in token registry
 	store := ctx.KVStore(m.keeper.storeKey)

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,9 @@ func (m Migrator) MigrateBNB(ctx sdk.Context) (bool, error) {`
`29`	`29`	`}`
`30`	`30`	`token, err := m.keeper.GetTokenSettings(ctx, badDenom)`
`31`	`31`	`if err != nil {`
`32`		`- return false, err`
	`32`	`+ ctx.Logger().Error("leverage migration skipped due to missing token", "err", err.Error())`
	`33`	`+ // If it's not a registered token, then we don't need to run this migration`
	`34`	`+ return false, nil`
`33`	`35`	`}`
`34`	`36`	`// Delete previous entry in token registry`
`35`	`37`	`store := ctx.KVStore(m.keeper.storeKey)`