diff --git a/README.md b/README.md index 548cb2a..dcc78ff 100644 --- a/README.md +++ b/README.md @@ -12,11 +12,16 @@ This is the GitHub project for the 2023 State Farm Coding Competition Round 1 an - 7:35pm CDT - [Issues Creating Branch in GitHub](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/5) - [Python project was missing data/ folder](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/7) - - 8:22 CDT + - 8:22pm CDT - [Fixed Final Node Test Typo](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/3) - [Fixed int to Integer Type Fix for Java Test 8 + Stub Method](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/4) - - 8:37 CDT + - 8:37pm CDT - [Cleaning up "round 1" folder ](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/6) + - 9:21 CDT + - **Test 12 is no longer required to pass before doing bonus credit** + - If you don't do Test 12, your score will NOT be impacted + - Test 12 MAY still be completed for bonus credit + - Please see the [Contradictory method documentation issue](https://github.com/StateFarmInsCodingCompetition/2023-StateFarm-CodingCompetition/issues/8#issuecomment-1763239724) for description and expected output(s) - October 6, 2023 - Publishing initial repo, including help guides and skeleton projects - This is to just get you started -- making sure your computer is setup, that you are able to build and run the project (including unit tests), and getting familiar with the structure. - The Problem Statement and relevant JSON files will be published at the start of Round 1 diff --git a/java/src/main/java/com/statefarm/codingcompetition/simpledatatool/controller/SimpleDataTool.java b/java/src/main/java/com/statefarm/codingcompetition/simpledatatool/controller/SimpleDataTool.java index 046dd56..b1e78b5 100644 --- a/java/src/main/java/com/statefarm/codingcompetition/simpledatatool/controller/SimpleDataTool.java +++ b/java/src/main/java/com/statefarm/codingcompetition/simpledatatool/controller/SimpleDataTool.java @@ -219,7 +219,10 @@ public float calculateDisasterClaimDensity(int id) { // region TestSet4 /** - * Gets the top three months with the highest total claim cost + * Gets the top three months with the highest number of claims + * + * OPTIONAL! OPTIONAL! OPTIONAL! + * AS OF 9:21CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS * * Hint: * - Month should be full name like 01 is January and 12 is December diff --git a/java/src/test/java/com/statefarm/codingcompetition/simpledatatool/TestSet4.java b/java/src/test/java/com/statefarm/codingcompetition/simpledatatool/TestSet4.java index fbd3469..dfbedb1 100644 --- a/java/src/test/java/com/statefarm/codingcompetition/simpledatatool/TestSet4.java +++ b/java/src/test/java/com/statefarm/codingcompetition/simpledatatool/TestSet4.java @@ -16,6 +16,10 @@ public void initialize() { controller = new SimpleDataTool(); } + /** + * OPTIONAL! OPTIONAL! OPTIONAL! + * AS OF 9:21CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS + */ @Test public void test12_getTopThreeMonthsWithHighestNumOfClaimsDesc() { String[] topThreeMonths = controller.getTopThreeMonthsWithHighestNumOfClaimsDesc(); diff --git a/nodejs/application.test.js b/nodejs/application.test.js index 9dff448..4e07aea 100644 --- a/nodejs/application.test.js +++ b/nodejs/application.test.js @@ -117,6 +117,10 @@ describe("Test Set Three", () => { }); describe("Test Set Four", () => { + /** + * OPTIONAL! OPTIONAL! OPTIONAL! + * AS OF 9:21 CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS + */ test("Test 12 - getTopThreeMonthsWithHighestNumOfClaimsDesc", () => { const topThreeMonths = controller.getTopThreeMonthsWithHighestNumOfClaimsDesc(); diff --git a/nodejs/simpleDataTool.js b/nodejs/simpleDataTool.js index 784f15b..9d34324 100644 --- a/nodejs/simpleDataTool.js +++ b/nodejs/simpleDataTool.js @@ -156,7 +156,10 @@ class SimpleDataTool { /** * Gets the top three months with the highest total claim cost. - * + * + * OPTIONAL! OPTIONAL! OPTIONAL! + * AS OF 9:21 CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS + * * Hint: * Month should be full name like 01 is January and 12 is December. * Year should be full four-digit year. diff --git a/python/simple_data_tool.py b/python/simple_data_tool.py index f57ad2f..5391073 100644 --- a/python/simple_data_tool.py +++ b/python/simple_data_tool.py @@ -221,7 +221,10 @@ def calculate_disaster_claim_density(self, disaster_id): # region TestSetFour def get_top_three_months_with_highest_num_of_claims_desc(self): - """Gets the top three months with the highest total claim cost + """Gets the top three months with the highest number of claims + + OPTIONAL! OPTIONAL! OPTIONAL! + AS OF 9:21CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS Hint: Month should be full name like 01 is January and 12 is December diff --git a/python/test/test_simple_data_tool.py b/python/test/test_simple_data_tool.py index 049250d..eb8b3a5 100644 --- a/python/test/test_simple_data_tool.py +++ b/python/test/test_simple_data_tool.py @@ -142,7 +142,12 @@ def test_calculate_disaster_claim_density(self, controller): class TestSetFour: def test_get_top_three_months_with_highest_num_of_claims_desc(self, controller): - """Test 12""" + """Test 12 + + OPTIONAL! OPTIONAL! OPTIONAL! + AS OF 9:21CDT, TEST IS OPTIONAL. SEE GITHUB ISSUE #8 FOR MORE DETAILS + + """ top_three_months = controller.get_top_three_months_with_highest_num_of_claims_desc() assert len(top_three_months) == 3 assert top_three_months[0] == 'April 2023'