[multiple] V2 embedding plugins use compileOnly (flutter#2232)

Michael Klimushyn · web-flow · commit a1fffa6e4da7 · 2019-10-25T15:00:55.000-07:00
Fixes possible version conflict issues. This would cause runtime class not found errors if any of these plugins relied on `Lifecycle` at runtime, but they do not.

Test is pending in flutter/plugin_tools#62.
diff --git a/packages/android_intent/CHANGELOG.md b/packages/android_intent/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.3.4+4
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.3.4+3
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/android_intent/android/build.gradle b/packages/android_intent/android/build.gradle
@@ -75,9 +75,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/android_intent/pubspec.yaml b/packages/android_intent/pubspec.yaml
@@ -2,7 +2,7 @@ name: android_intent
 description: Flutter plugin for launching Android Intents. Not supported on iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/android_intent
-version: 0.3.4+3
+version: 0.3.4+4
 
 flutter:
   plugin:
diff --git a/packages/battery/CHANGELOG.md b/packages/battery/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.3.1+2
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.3.1+1
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/battery/android/build.gradle b/packages/battery/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/battery/pubspec.yaml b/packages/battery/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for accessing information about the battery state
   (full, charging, discharging) on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/battery
-version: 0.3.1+1
+version: 0.3.1+2
 
 flutter:
   plugin:
diff --git a/packages/camera/CHANGELOG.md b/packages/camera/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.5.6+2
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.5.6+1
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/camera/android/build.gradle b/packages/camera/android/build.gradle
@@ -79,9 +79,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml
@@ -2,7 +2,7 @@ name: camera
 description: A Flutter plugin for getting information about and controlling the
   camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
   and streaming image buffers to dart.
-version: 0.5.6+1
+version: 0.5.6+2
 
 authors:
   - Flutter Team <flutter-dev@googlegroups.com>
diff --git a/packages/connectivity/CHANGELOG.md b/packages/connectivity/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.4.5+2
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.4.5+1
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/connectivity/android/build.gradle b/packages/connectivity/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/connectivity/pubspec.yaml b/packages/connectivity/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for discovering the state of the network (WiFi &
   mobile/cellular) connectivity on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity
-version: 0.4.5+1
+version: 0.4.5+2
 
 flutter:
   plugin:
diff --git a/packages/device_info/CHANGELOG.md b/packages/device_info/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.4.1+1
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.4.1
 
 * Support the v2 Android embedding.
diff --git a/packages/device_info/android/build.gradle b/packages/device_info/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/device_info/pubspec.yaml b/packages/device_info/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin providing detailed information about the device
   (make, model, etc.), and Android or iOS version the app is running on.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/device_info
-version: 0.4.1
+version: 0.4.1+1
 
 flutter:
   plugin:
diff --git a/packages/in_app_purchase/CHANGELOG.md b/packages/in_app_purchase/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.2.2+2
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.2.2+1
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/in_app_purchase/android/build.gradle b/packages/in_app_purchase/android/build.gradle
@@ -73,9 +73,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/in_app_purchase/pubspec.yaml b/packages/in_app_purchase/pubspec.yaml
@@ -2,7 +2,7 @@ name: in_app_purchase
 description: A Flutter plugin for in-app purchases. Exposes APIs for making in-app purchases through the App Store and Google Play.
 author:  Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase
-version: 0.2.2+1
+version: 0.2.2+2
 
 
 dependencies:
diff --git a/packages/package_info/CHANGELOG.md b/packages/package_info/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.4.0+10
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.4.0+9
 
 * Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
diff --git a/packages/package_info/android/build.gradle b/packages/package_info/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/package_info/pubspec.yaml b/packages/package_info/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for querying information about the application
   package, such as CFBundleVersion on iOS or versionCode on Android.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/package_info
-version: 0.4.0+9
+version: 0.4.0+10
 
 flutter:
   plugin:
diff --git a/packages/sensors/CHANGELOG.md b/packages/sensors/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.4.1+1
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
 ## 0.4.1
 
 * Support the v2 Android embedder.
diff --git a/packages/sensors/android/build.gradle b/packages/sensors/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/sensors/pubspec.yaml b/packages/sensors/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for accessing the Android and iOS accelerometer and
   gyroscope sensors.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/sensors
-version: 0.4.1
+version: 0.4.1+1
 
 flutter:
   plugin:
diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.6.3+1
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.6.3
 
 * Support the v2 Android embedder.
diff --git a/packages/share/android/build.gradle b/packages/share/android/build.gradle
@@ -64,9 +64,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for sharing content via the platform share UI, using
   the ACTION_SEND intent on Android and UIActivityViewController on iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/share
-version: 0.6.3
+version: 0.6.3+1
 
 flutter:
   plugin:
diff --git a/packages/shared_preferences/CHANGELOG.md b/packages/shared_preferences/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.5.4+1
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 0.5.4
 
 * Support the v2 Android embedding.
diff --git a/packages/shared_preferences/android/build.gradle b/packages/shared_preferences/android/build.gradle
@@ -72,9 +72,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/shared_preferences/pubspec.yaml b/packages/shared_preferences/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for reading and writing simple key-value pairs.
   Wraps NSUserDefaults on iOS and SharedPreferences on Android.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences
-version: 0.5.4
+version: 0.5.4+1
 
 flutter:
   plugin:
diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 5.2.5
+
+* Include lifecycle dependency as a compileOnly one on Android to resolve
+  potential version conflicts with other transitive libraries.
+
 ## 5.2.4
 
 * Use `package:url_launcher_platform_interface` to get the platform-specific implementation.
diff --git a/packages/url_launcher/url_launcher/android/build.gradle b/packages/url_launcher/url_launcher/android/build.gradle
@@ -75,9 +75,9 @@ afterEvaluate {
         android {
             dependencies {
                 def lifecycle_version = "1.1.1"
-                api "android.arch.lifecycle:runtime:$lifecycle_version"
-                api "android.arch.lifecycle:common:$lifecycle_version"
-                api "android.arch.lifecycle:common-java8:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common:$lifecycle_version"
+                compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"
             }
         }
     }
diff --git a/packages/url_launcher/url_launcher/pubspec.yaml b/packages/url_launcher/url_launcher/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL on Android and iOS. Supports
   web, phone, SMS, and email schemes.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
-version: 5.2.4
+version: 5.2.5
 
 flutter:
   plugin:

Original file line number	Diff line number	Diff line change
`@@ -75,9 +75,9 @@ afterEvaluate {`
`75`	`75`	`android {`
`76`	`76`	`dependencies {`
`77`	`77`	`def lifecycle_version = "1.1.1"`
`78`		`- api "android.arch.lifecycle:runtime:$lifecycle_version"`
`79`		`- api "android.arch.lifecycle:common:$lifecycle_version"`
`80`		`- api "android.arch.lifecycle:common-java8:$lifecycle_version"`
	`78`	`+ compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"`
	`79`	`+ compileOnly "android.arch.lifecycle:common:$lifecycle_version"`
	`80`	`+ compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,9 @@ afterEvaluate {`
`64`	`64`	`android {`
`65`	`65`	`dependencies {`
`66`	`66`	`def lifecycle_version = "1.1.1"`
`67`		`- api "android.arch.lifecycle:runtime:$lifecycle_version"`
`68`		`- api "android.arch.lifecycle:common:$lifecycle_version"`
`69`		`- api "android.arch.lifecycle:common-java8:$lifecycle_version"`
	`67`	`+ compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"`
	`68`	`+ compileOnly "android.arch.lifecycle:common:$lifecycle_version"`
	`69`	`+ compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,9 @@ afterEvaluate {`
`79`	`79`	`android {`
`80`	`80`	`dependencies {`
`81`	`81`	`def lifecycle_version = "1.1.1"`
`82`		`- api "android.arch.lifecycle:runtime:$lifecycle_version"`
`83`		`- api "android.arch.lifecycle:common:$lifecycle_version"`
`84`		`- api "android.arch.lifecycle:common-java8:$lifecycle_version"`
	`82`	`+ compileOnly "android.arch.lifecycle:runtime:$lifecycle_version"`
	`83`	`+ compileOnly "android.arch.lifecycle:common:$lifecycle_version"`
	`84`	`+ compileOnly "android.arch.lifecycle:common-java8:$lifecycle_version"`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`	`}`