adding tests [#149832554]

Author: jannakha

src/actions/claimPublications.js

@@ -14,10 +14,6 @@ export const POSSIBLY_YOUR_PUBLICATIONS_LOADING = 'POSSIBLY_YOUR_PUBLICATIONS_LO
 export const POSSIBLY_YOUR_PUBLICATIONS_COMPLETED = 'POSSIBLY_YOUR_PUBLICATIONS_COMPLETED';
 export const POSSIBLY_YOUR_PUBLICATIONS_FAILED = 'POSSIBLY_YOUR_PUBLICATIONS_FAILED';
 
-export const LATEST_PUBLICATIONS_LOADING = 'LATEST_PUBLICATIONS_LOADING';
-export const LATEST_PUBLICATIONS_COMPLETED = 'LATEST_PUBLICATIONS_COMPLETED';
-export const LATEST_PUBLICATIONS_FAILED = 'LATEST_PUBLICATIONS_FAILED';
-
 export const COUNT_POSSIBLY_YOUR_PUBLICATIONS_LOADING = 'COUNT_POSSIBLY_YOUR_PUBLICATIONS_LOADING';
 export const COUNT_POSSIBLY_YOUR_PUBLICATIONS_COMPLETED = 'COUNT_POSSIBLY_YOUR_PUBLICATIONS_COMPLETED';
 export const COUNT_POSSIBLY_YOUR_PUBLICATIONS_FAILED = 'COUNT_POSSIBLY_YOUR_PUBLICATIONS_FAILED';

src/modules/App/containers/App.js

@@ -14,6 +14,5 @@ function mapDispatchToProps(dispatch) {
         actions: bindActionCreators(actions, dispatch)
     };
 }
-
 const AppContainer = connect(mapStateToProps, mapDispatchToProps)(App);
 export default AppContainer;

src/modules/PublicationForm/components/Forms/BookForm.js

@@ -55,7 +55,6 @@ export default class BookForm extends Component {
                 <StandardCard title={txt.authors.title} help={txt.authors.help}>
                     <Field
                         component={ContributorsEditorField}
-                        showIdentifierLookup
                         name="authors"
                         locale={{contributorSuffix: txt.authors.suffix}}
                         showContributorAssignment

src/modules/SharedComponents/ContributorsEditor/components/ContributorForm.js

@@ -6,9 +6,9 @@ import RaisedButton from 'material-ui/RaisedButton';
 
 import {connect} from 'react-redux';
 import {bindActionCreators} from 'redux';
-import * as actions from 'actions';
+import * as actions from 'actions/authors';
 
-class ContributorForm extends Component {
+export class ContributorForm extends Component {
 
     static propTypes = {
         authorsList: PropTypes.array,
@@ -43,12 +43,12 @@ class ContributorForm extends Component {
         // I need to catch scrolling event of scrolled container (which is not a window) to set position of autosuggest list when user scrolls
         // another solution, close the box when user tries to scroll
         const div = document.querySelector('div.layout-fill.align-stretch');
-        div.addEventListener('scroll', this.handleParentContainerScroll.bind(this));
+        if (div) div.addEventListener('scroll', this.handleParentContainerScroll.bind(this));
     }
 
     componentWillUnmount() {
         const div = document.querySelector('div.layout-fill.align-stretch');
-        div.removeEventListener('scroll', this.handleParentContainerScroll.bind(this));
+        if (div) div.removeEventListener('scroll', this.handleParentContainerScroll.bind(this));
     }
 
     handleParentContainerScroll() {
@@ -70,7 +70,7 @@ class ContributorForm extends Component {
         });
 
         // move focus to name as published text field after item was added
-        this.refs.nameAsPublishedField.focus();
+        if (this.refs.nameAsPublishedField) this.refs.nameAsPublishedField.focus();
     }
 
     _onNameChanged = (event, newValue) => {
@@ -104,8 +104,8 @@ class ContributorForm extends Component {
         const autoCompleteDataFormat = {text: 'displayName', value: 'aut_id'};
 
         return (
-            <div className="columns contributors dataList">
-                <div className="column contributorsEntry">
+            <div className="columns">
+                <div className="column">
                     <TextField
                         fullWidth
                         ref="nameAsPublishedField"
@@ -118,7 +118,7 @@ class ContributorForm extends Component {
                 </div>
                 {
                     this.props.showIdentifierLookup &&
-                    <div className="column contributorsLinking">
+                    <div className="column">
                         <AutoComplete
                             disabled={this.props.disabled || this.state.nameAsPublished.trim().length === 0}
                             listStyle={{maxHeight: 200, overflow: 'auto'}}
@@ -137,7 +137,7 @@ class ContributorForm extends Component {
                         />
                     </div>
                 }
-                <div className="column is-narrow contributorsButton">
+                <div className="column is-narrow">
                     <RaisedButton
                         className="is-mui-spacing-button"
                         fullWidth
@@ -153,7 +153,7 @@ class ContributorForm extends Component {
 
 const mapStateToProps = (state) => {
     return {
-        authorsList: state.get('authorsReducer').authorsList || []
+        authorsList: state.get('authorsReducer') ? state.get('authorsReducer').authorsList : []
     };
 };
 

src/modules/SharedComponents/ContributorsEditor/components/ContributorForm.snapshot.test.js

@@ -0,0 +1,96 @@
+jest.dontMock('./ContributorForm');
+
+import { mount } from 'enzyme';
+import { shallow } from 'enzyme';
+import toJson from 'enzyme-to-json';
+import React from 'react';
+import {ContributorForm} from './ContributorForm';
+import getMuiTheme from 'material-ui/styles/getMuiTheme';
+import PropTypes from 'prop-types';
+import {Provider} from 'react-redux';
+import Immutable from 'immutable';
+import injectTapEventPlugin from 'react-tap-event-plugin';
+import {authorsSearch} from 'mock/data/authors';
+
+beforeAll(() => {
+    injectTapEventPlugin();
+});
+
+const create = () => {
+    const initialState = Immutable.Map();
+
+    const store = {
+        getState: jest.fn(() => (initialState)),
+        dispatch: jest.fn(),
+        subscribe: jest.fn()
+    };
+    const next = jest.fn();
+    const invoke = (action) => thunk(store)(next)(action);
+    return {store, next, invoke}
+};
+
+function setup({authorsList, onAdd, showIdentifierLookup, actions, disabled, isMount}){
+
+    const props = {
+        authorsList: authorsList || [], // : PropTypes.array,
+        onAdd: onAdd || jest.fn(), // : PropTypes.func.isRequired,
+        showIdentifierLookup: showIdentifierLookup || false, // : PropTypes.bool,
+        actions: actions || {}, // : PropTypes.object.isRequired,
+        disabled // : PropTypes.bool
+        //locale, // : PropTypes.object,
+    };
+
+    if (isMount) {
+        return mount(
+            <Provider store={create().store}>
+                <ContributorForm {...props} />
+            </Provider>, {
+                context: {
+                    muiTheme: getMuiTheme()
+                },
+                childContextTypes: {
+                    muiTheme: PropTypes.object.isRequired
+                }
+            });
+    }
+
+    return shallow(<Provider store={create().store}><ContributorForm {...props} /></Provider>);
+}
+
+
+
+describe('ContributorForm tests ', () => {
+    it('rendering display name field only', () => {
+        const wrapper = setup({ isMount: true });
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+
+    it('rendering display name field and identifier field', () => {
+        const wrapper = setup({ showIdentifierLookup: true, isMount: true });
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+
+    it('loads authors when value is changed', () => {
+        const testFunction = jest.fn();
+        const wrapper = setup({ showIdentifierLookup: true, actions: { searchAuthors: testFunction } }).find('ContributorForm').dive();
+        wrapper.instance()._onUQIdentifierChanged('smith');
+        expect(testFunction).toBeCalled();
+    });
+
+    it('sets display name of a contributor ', () => {
+        const testFunction = jest.fn();
+        const wrapper = setup({ showIdentifierLookup: true, actions: { searchAuthors: testFunction } }).find('ContributorForm').dive();
+        expect(wrapper.state.nameAsPublished).toBeFalsy();
+        wrapper.instance()._onNameChanged({}, 'J. Smith');
+        expect(wrapper.state().nameAsPublished).toEqual('J. Smith');
+    });
+
+
+    it('selects author identifier, calls add contributor ', () => {
+        const testFunction = jest.fn();
+        const wrapper = setup({ showIdentifierLookup: true, onAdd: testFunction }).find('ContributorForm').dive();
+        wrapper.instance()._onUQIdentifierSelected(authorsSearch.data[0], 0);
+        expect(testFunction).toBeCalled();
+    });
+
+});

src/modules/SharedComponents/ContributorsEditor/components/ContributorRowHeader.snapshot.test.js

@@ -0,0 +1,37 @@
+jest.dontMock('./ContributorRowHeader');
+
+import { shallow } from 'enzyme';
+import toJson from 'enzyme-to-json';
+import React from 'react';
+import ContributorRowHeader from './ContributorRowHeader';
+
+function setup({onDeleteAll, showIdentifierLookup, showContributorAssignment, disabled}){
+
+    const props = {
+        onDeleteAll: onDeleteAll || jest.fn(), // : PropTypes.func.isRequired,
+        showIdentifierLookup: showIdentifierLookup || false, // : PropTypes.bool,
+        showContributorAssignment: showContributorAssignment || false, // : PropTypes.bool,
+        // locale, // : PropTypes.object,
+        disabled: disabled || false // : PropTypes.bool
+    };
+
+    return shallow(<ContributorRowHeader {...props} />);
+}
+
+describe('ContributorRowHeader renders ', () => {
+
+    it('header for contributor editor control with name and delete all button only', () => {
+        const wrapper = setup({ });
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+
+    it('header for contributor editor control with all options', () => {
+        const wrapper = setup({ showIdentifierLookup: true, showContributorAssignment: true });
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+
+    it('header for contributor editor control with delete all disabled', () => {
+        const wrapper = setup({ disabled: true });
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+});

src/modules/SharedComponents/ContributorsEditor/components/ContributorsEditor.js

@@ -7,7 +7,7 @@ import ContributorForm from './ContributorForm';
 import {Alert} from 'uqlibrary-react-toolbox';
 
 
-class ContributorsEditor extends Component {
+export class ContributorsEditor extends Component {
 
     static propTypes = {
         showIdentifierLookup: PropTypes.bool,
@@ -60,7 +60,7 @@ class ContributorsEditor extends Component {
             }, () => {
                 // try to automatically select contributor if they are a current author
                 if (this.props.author && contributor.aut_id === this.props.author.aut_id) {
-                    this.onContributorAssigned(contributor, this.state.contributors.length - 1);
+                    this.assignContributor(contributor, this.state.contributors.length - 1);
                 }
             });
         }
@@ -102,7 +102,7 @@ class ContributorsEditor extends Component {
         });
     }
 
-    onContributorAssigned = (contributor, index) => {
+    assignContributor = (contributor, index) => {
         const newContributors = this.state.contributors.map((item, itemIndex) => (
             {
                 ...item,
@@ -131,7 +131,7 @@ class ContributorsEditor extends Component {
                 disabled={this.props.disabled}
                 showContributorAssignment={this.props.showContributorAssignment}
                 disabledContributorAssignment={this.state.isCurrentAuthorSelected}
-                onContributorAssigned={this.onContributorAssigned} />
+                onContributorAssigned={this.assignContributor} />
         );
 
         return (