fix: propagate error on target.Close() in copyFile

vedant21-oss · vedant21-oss · commit 1e3e5df4526a · 2026-04-28T22:20:01.000+05:30
diff --git a/pkg/unikontainers/utils.go b/pkg/unikontainers/utils.go
@@ -62,14 +62,16 @@ func copyFile(sourceFile string, targetPath string) error {
 	if err != nil {
 		return err
 	}
-	defer target.Close()
 
 	_, err = io.Copy(target, source)
+	
+	closeErr := target.Close()
+	
 	if err != nil {
 		return err
 	}
-
-	return nil
+	
+	return closeErr
 }
 
 // move sourceFile to targetDir

Original file line number	Diff line number	Diff line change
`@@ -62,14 +62,16 @@ func copyFile(sourceFile string, targetPath string) error {`
`62`	`62`	`if err != nil {`
`63`	`63`	`return err`
`64`	`64`	`}`
`65`		`- defer target.Close()`
`66`	`65`
`67`	`66`	`_, err = io.Copy(target, source)`
	`67`	`+`
	`68`	`+ closeErr := target.Close()`
	`69`	`+`
`68`	`70`	`if err != nil {`
`69`	`71`	`return err`
`70`	`72`	`}`
`71`		`-`
`72`		`- return nil`
	`73`	`+`
	`74`	`+ return closeErr`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`// move sourceFile to targetDir`