From 1f50577cd06ca37ffb4498e5d4b1354ae8f85ca0 Mon Sep 17 00:00:00 2001 From: hemang1404 Date: Tue, 28 Apr 2026 18:42:50 +0000 Subject: [PATCH] perf: optimize FormatNsenterInfo string building This commit replaces strings.Builder with bytes.Buffer to prevent an unnecessary intermediate string to byte slice allocation. Fixes: #501 Signed-off-by: hemang1404 --- pkg/unikontainers/unikontainers.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/unikontainers/unikontainers.go b/pkg/unikontainers/unikontainers.go index d63809bd..5b430182 100644 --- a/pkg/unikontainers/unikontainers.go +++ b/pkg/unikontainers/unikontainers.go @@ -990,20 +990,20 @@ func (u *Unikontainer) FormatNsenterInfo() (rdr io.Reader, retErr error) { }) } - var nsStringBuilder strings.Builder + var nsBuf bytes.Buffer if writePaths { for i := 0; i < numNS; i++ { if nsPaths[i] != "" { - if nsStringBuilder.Len() > 0 { - nsStringBuilder.WriteString(",") + if nsBuf.Len() > 0 { + nsBuf.WriteString(",") } - nsStringBuilder.WriteString(nsPaths[i]) + nsBuf.WriteString(nsPaths[i]) } } r.AddData(&bytemsg{ Type: nsPathsAttr, - Value: []byte(nsStringBuilder.String()), + Value: nsBuf.Bytes(), }) }