Fix term tag#407
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
540ea73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1495f77c.utcode-learn.pages.dev |
| Branch Preview URL: | https://fix-term-tag.utcode-learn.pages.dev |
chvmvd
reviewed
Oct 1, 2023
Contributor
chvmvd
left a comment
chvmvd
left a comment
There was a problem hiding this comment.
definition.jsの差分は今回関係ないので抜きたいのと、Prettierを書けてほしいです。
(switched to another branch) This reverts commit fd399b8.
chvmvd
reviewed
Oct 2, 2023
| // referencePageTitleがundefinedならばエラーを投げる (明らかに人的ミスのため) | ||
| if (referencePageTitle === undefined) { | ||
| throw new Error( | ||
| `The page title of the reference " ${term.referencePage} " \n is not defined in \n[ src/components/Term/definition.js/, referencePageTitles ]`, |
Contributor
There was a problem hiding this comment.
Suggested change
| `The page title of the reference " ${term.referencePage} " \n is not defined in \n[ src/components/Term/definition.js/, referencePageTitles ]`, | |
| `The title for the reference page "${term.referencePage}" is not defined in the "referencePageTitles" object within the file "src/components/Term/definition.js".`, |
Contributor
Author
There was a problem hiding this comment.
改行も[]もあったほうが読みやすいかなあ、と。
Contributor
There was a problem hiding this comment.
改行は、こちらで指定するものではないような気がします。br要素の使い方と同じ感じで。
[]に関しては、この[]の用法がいまいちよくわからなかったです。この[]にどのような意味があるのかが、わからなかった感じです。
Contributor
Author
There was a problem hiding this comment.
[]は消しておきます。改行は、ユーザーが見るものではないのでリンクと文章の分離ができればokだと思ってます。
Contributor
There was a problem hiding this comment.
一般的に、改行はユーザーの端末が自身の端末の画面サイズに合わせて自分で入れるものなので、こちら側が指定すると不適切なところに改行が入ってしまうことがあるのかなとは思いました。エラーメッセージについてこれがどうなのかはわかりませんが。
Contributor
Author
|
マージします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.