モジュール化の説明の例を変更 (#474)#492
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
12daa13
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://495d5e96.utcode-learn.pages.dev |
| Branch Preview URL: | https://update-modularization.utcode-learn.pages.dev |
aster-void
approved these changes
Oct 19, 2023
Contributor
aster-void
left a comment
aster-void
left a comment
There was a problem hiding this comment.
引数が長いのが気になりますがいいと思います！
chvmvd
reviewed
Oct 19, 2023
Contributor
|
引数の長さは、むしろ減らすとどういう実装かがわからなくなって、結局実装を見ないといけなくなるので、これぐらいかなあとは思います。 |
chvmvd
reviewed
Oct 19, 2023
chvmvd
approved these changes
Oct 19, 2023
Contributor
|
それでは、ビルドができたらマージしちゃいますか。 |
Contributor
Author
|
考えるべきことが少なくなるので、読みやすい -> もう書いてある？ |
Contributor
それはそうですねw |
Contributor
それはその通りなんですけど、モジュール化するメリットの一つであることは確かなのであったほうがいいと思います。 |
Contributor
|
授業始まる前にはマージしてデプロイしていただきたいです！ |
Contributor
|
OKです！そこは、安心してください！ |
Contributor
確かに、明示的に書くのはありだと思う。 |
Contributor
|
とりあえずは、マージしますか。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #474
@chvmvd
@fridge0
こんな感じでどうでしょう