Skip to content

コンポネントのimportを一か所にまとめました#497

Merged
aster-void merged 14 commits into
masterfrom
import-all-scope
Oct 25, 2023
Merged

コンポネントのimportを一か所にまとめました#497
aster-void merged 14 commits into
masterfrom
import-all-scope

Conversation

@aster-void
Copy link
Copy Markdown
Contributor

cf. https://docusaurus.io/docs/markdown-features/react#mdx-component-scope
今後新しいドキュメントを作るときは何もしなくても使えます
新しいコンポネントを定義するときはsrc/theme/MDXComponentsで定義できます

@aster-void aster-void requested review from chelproc and chvmvd October 20, 2023 12:50
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Oct 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f6065c
Status: ✅  Deploy successful!
Preview URL: https://a41c0efe.utcode-learn.pages.dev
Branch Preview URL: https://import-all-scope.utcode-learn.pages.dev

View logs

Copy link
Copy Markdown
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ナイスです!謎なコメントがあるので、消しても良いかなと。

Comment thread src/theme/MDXComponents.js
@aster-void
Copy link
Copy Markdown
Contributor Author

aster-void commented Oct 21, 2023

謎なコメントがあるので、消しても良いかなと。

あとdocs側に自動でエクスポートされてるのは自明では無いのでコメント残しておきます

@chvmvd
Copy link
Copy Markdown
Contributor

chvmvd commented Oct 21, 2023

まあ、それはそういうコンポーネントだから、分かる気はする。

@aster-void
Copy link
Copy Markdown
Contributor Author

調べないと分からないと思います。
ちなみにファイルは元々なかったので新しく作ったやつです

@chvmvd
Copy link
Copy Markdown
Contributor

chvmvd commented Oct 22, 2023

まあ、軽くコメント入れるのはありか。

Comment thread src/theme/MDXComponents.js
Comment thread src/theme/MDXComponents.js Outdated
@aster-void aster-void requested a review from chvmvd October 23, 2023 03:57
Comment thread src/theme/MDXComponents.js Outdated
Copy link
Copy Markdown
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重複がありそうなのと、変な空行がある。
後は、コンポネント
ついでに、コメントは、文だから、大文字で初めて、ピリオドで終わるかなあ。

@aster-void aster-void requested a review from chvmvd October 24, 2023 07:18
Comment thread src/theme/MDXComponents.js Outdated
@aster-void aster-void requested a review from chvmvd October 24, 2023 23:04
Copy link
Copy Markdown
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様です。

@aster-void
Copy link
Copy Markdown
Contributor Author

conflict直したのでビルド通り次第マージします。

@aster-void aster-void merged commit 342b68c into master Oct 25, 2023
@aster-void aster-void deleted the import-all-scope branch October 25, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants