Termタグのtypeを省略できるように#561
Merged
Merged
Conversation
Contributor
Author
|
今は動くはずです |
Deploying with
|
| Latest commit: |
6925790
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8317931.utcode-learn.pages.dev |
| Branch Preview URL: | https://auto-type-term-tags.utcode-learn.pages.dev |
Contributor
Author
|
prettierかけ忘れましたw |
chvmvd
reviewed
Nov 7, 2023
chvmvd
reviewed
Nov 7, 2023
Closed
chelproc
reviewed
Nov 8, 2023
Contributor
There was a problem hiding this comment.
短縮系を作るくらいなら全部短縮系の方がいいと思います:eyes:
Contributor
Author
There was a problem hiding this comment.
別 PR で短縮形(というかjavascriptなし)とjavascriptありを入れ替える予定です
Contributor
There was a problem hiding this comment.
そもそもtypeを指定することはほとんどないので、短縮形にしなくても良くないですか？使うところはjavascriptPropertyとcssPropertyで短縮できないところとかだから。
Contributor
Author
There was a problem hiding this comment.
とりあえず今回は見逃しますが、type-map内だけでも気になるので今度別PRでやります。
Contributor
There was a problem hiding this comment.
短縮できるところとできないところができてどれを省略するのか決めるの大変だから、そのままで良いんじゃない？
Contributor
Author
There was a problem hiding this comment.
むしろ今の状態のほうが javascript が入るかどうか考えるのが大変だと思います。
・html 系のタームは html が入ってない
・DOM・イベント・イベントハンドラ は javascriptが入ってない
・ほとんどの言語共通の「関数」には入ってるのに、より狭い「アロー関数」には入ってない。
などバラバラので、パリティすると考えれば
chelproc
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一部 (CSSプロパティなどの文字から判断できないもの、「truthyとfalsy」など使われ方の不明なものなど) 対応不可能なのでその場合は明示的に書いてください。