Fixed test

Author: vardius

README.md

@@ -46,13 +46,6 @@ func main() {
     pool := workerpool.New(poolSize)
     out := make(chan int, jobsAmount)
 
-    go func() {
-        // stop all workers after jobs are done
-        defer pool.Stop()
-        wg.Wait()
-        close(out)
-    }()
-
     pool.Start(workersAmount, func(i int) {
         defer wg.Done()
         out <- i
@@ -64,6 +57,13 @@ func main() {
         pool.Delegate(i)
     }
 
+    go func() {
+        // stop all workers after jobs are done
+        wg.Wait()
+        close(out)
+        pool.Stop()
+    }()
+
     sum := 0
     for n := range out {
         sum += n

doc.go

@@ -22,13 +22,6 @@ Basic example:
 		pool := workerpool.New(poolSize)
 		out := make(chan int, jobsAmount)
 
-		go func() {
-			// stop all workers after jobs are done
-			defer pool.Stop()
-			wg.Wait()
-			close(out)
-		}()
-
 		pool.Start(workersAmount, func(i int) {
 			defer wg.Done()
 			out <- i
@@ -40,6 +33,13 @@ Basic example:
 			pool.Delegate(i)
 		}
 
+		go func() {
+			// stop all workers after jobs are done
+			wg.Wait()
+			close(out)
+			pool.Stop()
+		}()
+
 		sum := 0
 		for n := range out {
 			sum += n

pool_test.go

@@ -14,6 +14,23 @@ func TestNew(t *testing.T) {
 		t.Fail()
 	}
 }
+func TestInvalidWorkersNumber(t *testing.T) {
+	pool := New(2)
+	defer pool.Stop()
+
+	if pool.Start(0, func() {}) == nil {
+		t.Fail()
+	}
+}
+
+func TestInvalidWorker(t *testing.T) {
+	pool := New(2)
+	defer pool.Stop()
+
+	if pool.Start(1, "worker") == nil {
+		t.Fail()
+	}
+}
 
 func TestWorkers(t *testing.T) {
 	delegateWorkToWorkers(t, 2, 3, 3) // same workers as jobs
@@ -27,12 +44,6 @@ func delegateWorkToWorkers(t *testing.T, poolSize int, jobsAmount int, workersAm
 	pool := New(poolSize)
 	out := make(chan int, jobsAmount)
 
-	go func() {
-		wg.Wait()
-		close(out)
-		pool.Stop()
-	}()
-
 	pool.Start(workersAmount, func(i int) {
 		defer wg.Done()
 		out <- i
@@ -44,6 +55,12 @@ func delegateWorkToWorkers(t *testing.T, poolSize int, jobsAmount int, workersAm
 		pool.Delegate(i)
 	}
 
+	go func() {
+		wg.Wait()
+		close(out)
+		pool.Stop()
+	}()
+
 	sum := 0
 	for n := range out {
 		sum += n