add some basic tests! (jekirl#332)

Author: infinitewarp

pgoapi/game_master.py

@@ -1,10 +1,11 @@
 import csv
 import re
+from os import path
 
 from six import iteritems
 
 
-class PokemonData:
+class PokemonData(object):
     def __init__(self):
         self.PkMn = 0
         self.BaseStamina = 0
@@ -37,7 +38,8 @@ def __init__(self):
 
 GAME_MASTER = {}
 
-with open("GAME_MASTER_POKEMON_v0_2.tsv") as tsvfile:
+_game_master_file_path = path.join(path.dirname(path.dirname(__file__)), "GAME_MASTER_POKEMON_v0_2.tsv")
+with open(_game_master_file_path) as tsvfile:
     tsvreader = csv.DictReader(tsvfile, delimiter='\t')
     attributes = []
     for row in tsvreader:

pgoapi/pokemon.py

@@ -2,15 +2,19 @@
 
 import json
 from math import sqrt
+from os import path
 
 from pgoapi.game_master import GAME_MASTER
 
 
-# TODO wrap this with some error handling?
-POKEMON_NAMES = json.load(open("pokemon.en.json"))
+POKEMON_NAMES = {}
 
+_names_file_path = path.join(path.dirname(path.dirname(__file__)), "pokemon.en.json")
+with open(_names_file_path) as jsonfile:
+    POKEMON_NAMES.update(json.load(jsonfile))
 
-class Pokemon:
+
+class Pokemon(object):
     # Used for calculating the pokemon level
     # source http://pokemongo.gamepress.gg/cp-multiplier
     CPM_calculation_increments = [
@@ -66,13 +70,13 @@ def __init__(self, pokemon_data, player_level=0,
         self.cpm_total = self.cp_multiplier + self.additional_cp_multiplier
         self.level_wild = self.get_level_by_cpm(self.cp_multiplier)
         self.level = self.get_level_by_cpm(self.cpm_total)
-        additional_data = GAME_MASTER[self.pokemon_id]
-        self.family_id = additional_data.FamilyId
+        additional_data = GAME_MASTER.get(self.pokemon_id)
+        self.family_id = additional_data.FamilyId if additional_data else None
 
         # Thanks to http://pokemongo.gamepress.gg/pokemon-stats-advanced for the magical formulas
-        attack = float(additional_data.BaseAttack)
-        defense = float(additional_data.BaseDefense)
-        stamina = float(additional_data.BaseStamina)
+        attack = float(additional_data.BaseAttack) if additional_data else 0.0
+        defense = float(additional_data.BaseDefense) if additional_data else 0.0
+        stamina = float(additional_data.BaseStamina) if additional_data else 0.0
         self.max_cp = ((attack + self.individual_attack) *
                        sqrt(defense + self.individual_defense) *
                        sqrt(stamina + self.individual_stamina) *

tests/__init__.py

@@ -0,0 +1,65 @@
+import unittest
+
+from pgoapi.pokemon import Pokemon
+
+
+mock_caught_eevee = {
+    'move_1': 221,
+    'move_2': 26,
+    'captured_cell_id': 9970561120513919632,
+    'pokeball': 1,
+    'pokemon_id': 133,
+    'creation_time_ms': 1469596340021,
+    'height_m': 0.2028486435644989,
+    'stamina_max': 69,
+    'weight_kg': 1.812894354329834,
+    'individual_defense': 3,
+    'cp_multiplier': 0.5822789072940417,
+    'stamina': 69,
+    'individual_stamina': 9,
+    'individual_attack': 15,
+    'cp': 546,
+    'id': 10537581451037376812
+}
+
+mock_wild_spearow = {
+    'move_1': 211,
+    'move_2': 45,
+    'pokemon_id': 21,
+    'height_m': 0.2692510320415297,
+    'stamina_max': 27,
+    'weight_kg': 1.8720885511213213,
+    'individual_defense': 5,
+    'cp_multiplier': 0.3210875988206512,
+    'stamina': 27,
+    'individual_stamina': 7,
+    'individual_attack': 9,
+    'cp': 97
+}
+
+
+class TestPokemon(unittest.TestCase):
+
+    def test_wild_spearow_data(self):
+        # Type: Spearow CP: 97, IV: 46.67, Lvl: 6.0, LvlWild: 6.0, MaxCP: 17, Score: 97, IV-Norm.: 47
+        p = Pokemon(mock_wild_spearow, 0, 'CP', {})
+        self.assertEqual(p.pokemon_type.decode('utf-8'), 'Spearow')
+        self.assertEqual(p.cp, 97)
+        self.assertEqual(round(p.iv, 2), 46.67)
+        self.assertEqual(p.level, 6.0)
+        self.assertEqual(p.level_wild, 6.0)
+        self.assertEqual(round(p.max_cp), 17)
+        self.assertEqual(p.score, 97)
+        self.assertEqual(round(p.iv_normalized), 47)
+
+    def test_caught_eevee_data(self):
+        # Type: Eevee CP: 546, IV: 60.00, Lvl: 19.0, LvlWild: 19.0, MaxCP: 675, Score: 546, IV-Norm.: 69
+        p = Pokemon(mock_caught_eevee, 22, 'CP', {})
+        self.assertEqual(p.pokemon_type.decode('utf-8'), 'Eevee')
+        self.assertEqual(p.cp, 546)
+        self.assertEqual(round(p.iv, 2), 60.00)
+        self.assertEqual(p.level, 19.0)
+        self.assertEqual(p.level_wild, 19.0)
+        self.assertEqual(round(p.max_cp), 675)
+        self.assertEqual(p.score, 546)
+        self.assertEqual(round(p.iv_normalized), 69)

tests/test_api.py

@@ -6,9 +6,11 @@ envlist = py27, py35
 commands =
   flake8 {toxinidir}
   isort -c -rc {toxinidir} -sg {toxworkdir}/*
+  nosetests
 deps =
   flake8
   isort
+  nose
   -r{toxinidir}/requirements.txt
 
 [flake8]