Skip to content

Commit 52bad2b

Browse files
fix: ad icon is not visible on audio description track list element on Safari (#8232)
1 parent 1a1adf3 commit 52bad2b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/css/components/_audio.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@
22
@extend .vjs-icon-audio;
33
}
44

5+
.video-js .vjs-audio-button + .vjs-menu .vjs-description-menu-item .vjs-menu-item-text .vjs-icon-placeholder,
56
.video-js .vjs-audio-button + .vjs-menu .vjs-main-desc-menu-item .vjs-menu-item-text .vjs-icon-placeholder {
67
vertical-align: middle;
78
display: inline-block;
89
margin-bottom: -0.1em;
910
}
1011

11-
// Mark a main-desc-menu-item (main + description) item with a trailing Audio Description icon
12+
// Mark a main-desc-menu-item (main + description) or description item with a trailing Audio Description icon
13+
.video-js .vjs-audio-button + .vjs-menu .vjs-description-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before,
1214
.video-js .vjs-audio-button + .vjs-menu .vjs-main-desc-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before {
1315
font-family: VideoJS;
1416
content: " \f12e";

src/js/control-bar/audio-track-controls/audio-track-menu-item.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class AudioTrackMenuItem extends MenuItem {
4949
const el = super.createEl(type, props, attrs);
5050
const parentSpan = el.querySelector('.vjs-menu-item-text');
5151

52-
if (this.options_.track.kind === 'main-desc') {
52+
if (['main-desc', 'description'].indexOf(this.options_.track.kind) >= 0) {
5353
parentSpan.appendChild(Dom.createEl('span', {
5454
className: 'vjs-icon-placeholder'
5555
}, {

0 commit comments

Comments
 (0)