chore: additional vjs ad errors

[wseymour15]

Description

Add additional errors to the video.js error interface regarding ads.

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chrome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
• Reviewed by Two Core Contributors

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (a57b07a) to head (012f79b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8623   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7636     7636           
  Branches     1835     1835           
=======================================
  Hits         6316     6316           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amtins]

@wseymour15 looks like there is a little typo ?

[wseymour15]

Good eye, PR for that update: #8628

It is not an urgent fix, so no need to rush a release for this one.

[thijstriemstra]

Interesting to see this being added, since it's a plugin/thirdparty library afaik (and shouldn't be "bloating" a core video.js).

[misteroneill]

Interesting to see this being added, since it's a plugin/thirdparty library afaik (and shouldn't be "bloating" a core video.js).

Yeah, we agree that it's not the ideal place for these constants, but was added in the interest of the simplicity of having a single mapping of error codes in Video.js and it had a fairly minimal impact on bundle size.

I think we will plan to build in a more configurable mechanism in the future. Ultimately, these would belong in a library like videojs-contrib-ads.

[thijstriemstra]

Thanks for the feedback.

in the interest of the simplicity

is always a red flag isn't it (when coming from a marketing department i'd imagine).

I think we will plan to build in a more configurable mechanism in the future. Ultimately, these would belong in a library like videojs-contrib-ads.

Nice! It seems to be a re-occuring theme though: #8634