Skip to content

fix(build): Use escaped dbl quotes to support building on Windows#8681

Merged
mister-ben merged 2 commits intovideojs:mainfrom
mister-ben:pkgjson-quotes
Apr 12, 2024
Merged

fix(build): Use escaped dbl quotes to support building on Windows#8681
mister-ben merged 2 commits intovideojs:mainfrom
mister-ben:pkgjson-quotes

Conversation

@mister-ben
Copy link
Contributor

Description

Using single quotes in the sass command doesn't work with Windows, causing sass to fail to locate imports.
Fixes #8149

Specific Changes proposed

Uses \" rather than ' within script strings in package.json.

@mister-ben mister-ben changed the title fix(build): Use quoted dbl quotes to support building on Windows fix(build): Use escaped dbl quotes to support building on Windows Apr 11, 2024
@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (af06f50) to head (750dfaf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8681   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files         113      113           
  Lines        7647     7647           
  Branches     1839     1839           
=======================================
  Hits         6336     6336           
  Misses       1311     1311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Still) Wrong path for font scss in video-js.scss on v8.0.4

2 participants