Skip to content

fix: Listen to taps on track controls#8809

Merged
mister-ben merged 1 commit intovideojs:mainfrom
mister-ben:fix-captions-controls
Jul 22, 2024
Merged

fix: Listen to taps on track controls#8809
mister-ben merged 1 commit intovideojs:mainfrom
mister-ben:fix-captions-controls

Conversation

@mister-ben
Copy link
Contributor

Description

The refactored text track controls aren't listening for tap events.

Specific Changes proposed

Add tap handler to done and reset buttons.
Fixes #8808

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (e78bcc7) to head (95123d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8809   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files         120      120           
  Lines        8022     8022           
  Branches     1925     1925           
=======================================
  Hits         6664     6664           
  Misses       1358     1358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch This PR can be added to a patch release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Captions Settings menu buttons don't work on mobile.

2 participants