fix: Resolves captions sizing issue when minified (v7)#9012
Merged
mister-ben merged 2 commits intovideojs:7.xfrom Mar 20, 2025
Merged
fix: Resolves captions sizing issue when minified (v7)#9012mister-ben merged 2 commits intovideojs:7.xfrom
mister-ben merged 2 commits intovideojs:7.xfrom
Conversation
Resolves captions sizing issue when minified videojs#8442
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
❌ Deploy Preview for zesty-marshmallow-73319e failed.
|
mister-ben
approved these changes
Mar 19, 2025
Contributor
mister-ben
left a comment
There was a problem hiding this comment.
Codecov upload fails because of changes in codecov which have been addressed in v8, but we know this won't affect coverage.
gkatsev
approved these changes
Mar 19, 2025
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves captions sizing issue when minified #8442
Description
This bug discussed and confirmed. A fix has been released shortly for videojs8 but verison 7 still haven't fixed. #8370
Specific Changes proposed
Same fix applied at #8442
Requirements Checklist
npm run docs:apito error