fix(component.js): Updated JS Doc for removeChild()#9070
Merged
heff merged 2 commits intovideojs:mainfrom Jul 12, 2025
Merged
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Contributor
Author
|
@gkatsev / @alex-barstow / @heff / @mister-ben Can you please review this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9070 +/- ##
==========================================
- Coverage 84.89% 84.31% -0.58%
==========================================
Files 120 120
Lines 8154 8154
Branches 1964 1964
==========================================
- Hits 6922 6875 -47
- Misses 1232 1279 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removeChild() in component.js was missing the string as an acceptable parameter due to which ts complaints.
Example : player.removeChild('controlBar');
Error : Argument of type 'string' is not assignable to parameter of type 'Component'
Specific Changes proposed
stringin the jsdoc for removeChild() in component.ts.Requirements Checklist
npm run docs:apito error