New package: wiremix-0.8.0

[dora-meowmeow]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

Local build testing

• I built this PR locally for my native architecture, (x86-64-glibc)

[classabbyamp]

it would be good to install the desktop file (with vinstall) and the sample config (with vsconf)

commit messages should follow the format from here and there should only be 1 commit per package (so 1 commit in the PR)

[dora-meowmeow]

it would be good to install the desktop file (with vinstall) and the sample config (with vsconf)

commit messages should follow the format from here and there should only be 1 commit per package (so 1 commit in the PR)

I haven't used the vfunctions in xbps but I will be definetly adding those two. Regarding commits, I'm not sure how I can merge all of the commits into 1 big commit and only PR that. I'll look into it(worse case just make another branch with 1 commit).

Additionally thank you so much for all of the fixes. I'm still learning and toying with xbps so showing me the right way to do some of this instead of just telling me its not good really helped.

[classabbyamp]

git reset --soft master && git commit then git push --force-with-lease

[dora-meowmeow]

Sorry for the mess, I initially screwed up a bit and pushed to master. Had to fix master branch of my fork. I hope this is satisfactory. As requested I added the desktop icon and conf. I also included the vlicense for the licenses (xlint did warn me on MIT but I included both for good measure).

Please let me know if you need anything else changed.

[dora-meowmeow]

hopefully I nailed it this time 😅

[classabbyamp]

so the reason cross-build is failing is it's trying to use libgit2 in the build.rs script to get version info. this is extra useless here because there will never be a git context to grab a version from.

on cross, build.rs runs for the host, so if we wanted to, we could move the libgit2-1.9-devel dependency to hostmakedepends, but it's better to just circumvent it altogether

so, add this patch:

we know this isn't going to be in a git repo, so get rid of a useless dependency
on libgit2.

--- a/build.rs
+++ b/build.rs
@@ -1,12 +1,3 @@
-use vergen_git2::{Emitter, Git2Builder};
-
 fn main() -> Result<(), Box<dyn std::error::Error>> {
-    // Put "git describe" output (ex. "v0.5.0-2-gbc03f8a-dirty") in
-    // VERGEN_GIT_DESCRIBE environment variable for use in --version output.
-    let describe = Git2Builder::default()
-        .describe(true, true, Some("v[0-9]*.[0-9]*.[0-9]*"))
-        .build()?;
-    Emitter::default().add_instructions(&describe)?.emit()?;
-
     Ok(())
 }

I called it srcpkgs/wiremix/patches/useless-git.patch

and...

[classabbyamp]

and btw, the commit message for new packages should include the version: New package: wiremix-0.8.0

[dora-meowmeow]

alright I am currently out for an hour or two. I'll do the patch and renaming in max 2-3 hours. Thanks for the help.

[dora-meowmeow]

I've compiled the package twice (x86_64, and i686) with the patch. Both compiled fine and x86_64 installed and worked in my machine. So hopefully, fingers crossed, this will be it.

I do have a question regarding patches. Are all the patches in patches folder ran when building a package? Is there way to specify it for a specific library(glibc or musl) or architecture compile? Sorry I am not that familiar with patching in general but would love to learn more 😅

[classabbyamp]

I do have a question regarding patches. Are all the patches in patches folder ran when building a package? Is there way to specify it for a specific library(glibc or musl) or architecture compile? Sorry I am not that familiar with patching in general but would love to learn more 😅

patches are always applied yes. if something is architecture-specific, it's probably a bad patch (i.e., it's better if it's written in an arch-agnostic way), but if necessary you can work around it a couple ways, like chromium does for example

[dora-meowmeow]

Hmm patch didn't seem to work :/. I'm going to tinker with it on xbps-src a bit (try to compile it to aarch64). Hopes it is something minor. If not maybe put libgit2.19-devel to hostmakedepends as suggested?

[classabbyamp]

you need to add the patch to git, look at the PR contents right now

[dora-meowmeow]

Yeah I was surprised to see my cross compile working 😅. I've pushed it with the patch this time, sorry for the brainfart.

[dora-meowmeow]

@classabbyamp my apologies, I didn't realized that the patch message was still broken. It should be fixed now.