chore(vite_pm_cli): enable lib tests by removing stale test = false#1661
Merged
fengmk2 merged 3 commits intoMay 22, 2026
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
approved these changes
May 22, 2026
fengmk2
deleted the
05-22-chore_vite_pm_cli_enable_lib_tests_by_removing_stale
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/vite_pm_cli/src/cli.rscontains real unit tests (#[cfg(test)] mod testswith#[test]cases around line 1146), butCargo.tomlhad[lib] test = false, which silently excluded them fromcargo test.cargo shear --fix(invoked viajust fmt) flagged and removed the obsoletetest = falseline so the existing tests are picked up.