From 16c565fdb2b5c6c41ac0055fd670cda2bf3134f2 Mon Sep 17 00:00:00 2001 From: Salman Muin Kayser Chishti <13schishti@gmail.com> Date: Tue, 28 Apr 2026 13:57:32 +0100 Subject: [PATCH 1/5] Upgrade GitHub Actions for Node 24 compatibility Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com> --- .github/actions/build-upstream/action.yml | 4 ++-- .../download-rolldown-binaries/action.yml | 2 +- .github/workflows/ci.yml | 8 ++++---- .github/workflows/e2e-test.yml | 8 ++++---- .github/workflows/release.yml | 16 ++++++++-------- .github/workflows/reusable-release-build.yml | 16 ++++++++-------- .github/workflows/test-vp-create.yml | 8 ++++---- 7 files changed, 31 insertions(+), 31 deletions(-) diff --git a/.github/actions/build-upstream/action.yml b/.github/actions/build-upstream/action.yml index 009c6b2300..5e7c702e8a 100644 --- a/.github/actions/build-upstream/action.yml +++ b/.github/actions/build-upstream/action.yml @@ -36,7 +36,7 @@ runs: # Cache NAPI bindings and Rust CLI binary (the slow parts, especially on Windows) - name: Restore NAPI binding cache id: cache-restore - uses: actions/cache/restore@94b89442628ad1d101e352b7ee38f30e1bef108e # v5 + uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | packages/cli/binding/*.node @@ -151,7 +151,7 @@ runs: - name: Save NAPI binding cache if: steps.cache-restore.outputs.cache-hit != 'true' - uses: actions/cache/save@94b89442628ad1d101e352b7ee38f30e1bef108e # v5 + uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | packages/cli/binding/*.node diff --git a/.github/actions/download-rolldown-binaries/action.yml b/.github/actions/download-rolldown-binaries/action.yml index edc3afb847..faea59be4f 100644 --- a/.github/actions/download-rolldown-binaries/action.yml +++ b/.github/actions/download-rolldown-binaries/action.yml @@ -50,7 +50,7 @@ runs: fi env: GITHUB_TOKEN: ${{ inputs.github-token }} - - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ inputs.upload == 'true' }} with: name: rolldown-binaries diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ed037eb9d..1b136e91f5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -230,7 +230,7 @@ jobs: - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -698,7 +698,7 @@ jobs: - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -742,7 +742,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -821,7 +821,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index 45799e26c0..461683407a 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -94,7 +94,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -117,7 +117,7 @@ jobs: ls -la tmp/tgz - name: Upload tgz artifacts - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-plus-packages-${{ matrix.os }} path: tmp/tgz/ @@ -373,13 +373,13 @@ jobs: shell: powershell run: Set-MpPreference -DisableRealtimeMonitoring $true - - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version: ${{ matrix.project.node-version }} package-manager-cache: false - name: Download vite-plus packages - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: vite-plus-packages-${{ matrix.os }} path: tmp/tgz diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a2547b6b01..c509d27e11 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -75,7 +75,7 @@ jobs: - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0 - - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version-file: .node-version package-manager-cache: false @@ -86,34 +86,34 @@ jobs: run: pnpm install - name: Download cli dist - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/dist pattern: cli merge-multiple: true - name: Download cli docs - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/docs pattern: cli-docs merge-multiple: true - name: Download cli binding - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/artifacts pattern: vite-plus-native-* - name: Download core dist - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/core/dist pattern: core merge-multiple: true - name: Download LICENSE files - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages pattern: licenses @@ -126,13 +126,13 @@ jobs: upload: 'false' - name: Download Rust CLI binaries - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: rust-cli-artifacts pattern: vite-global-cli-* - name: Download installer binaries (Windows) - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: installer-artifacts pattern: vp-setup-* diff --git a/.github/workflows/reusable-release-build.yml b/.github/workflows/reusable-release-build.yml index 5ba0575282..3facdd51ff 100644 --- a/.github/workflows/reusable-release-build.yml +++ b/.github/workflows/reusable-release-build.yml @@ -86,14 +86,14 @@ jobs: target: ${{ matrix.settings.target }} - name: Upload Vite+ native artifact - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-plus-native-${{ matrix.settings.target }} path: ./packages/cli/binding/*.node if-no-files-found: error - name: Upload Rust CLI binary artifact - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-global-cli-${{ matrix.settings.target }} path: | @@ -104,7 +104,7 @@ jobs: - name: Upload installer binary artifact (Windows only) if: contains(matrix.settings.target, 'windows') - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vp-setup-${{ matrix.settings.target }} path: ./target/${{ matrix.settings.target }}/release/vp-setup.exe @@ -116,7 +116,7 @@ jobs: rm ./packages/core/dist/**/*.node - name: Upload core dist - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ matrix.settings.target == 'x86_64-unknown-linux-gnu' }} with: name: core @@ -124,7 +124,7 @@ jobs: if-no-files-found: error - name: Upload prompts dist - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ matrix.settings.target == 'x86_64-unknown-linux-gnu' }} with: name: prompts @@ -132,7 +132,7 @@ jobs: if-no-files-found: error - name: Upload cli dist - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ matrix.settings.target == 'x86_64-unknown-linux-gnu' }} with: name: cli @@ -140,7 +140,7 @@ jobs: if-no-files-found: error - name: Upload cli docs - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ matrix.settings.target == 'x86_64-unknown-linux-gnu' }} with: name: cli-docs @@ -148,7 +148,7 @@ jobs: if-no-files-found: error - name: Upload LICENSE files - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ matrix.settings.target == 'x86_64-unknown-linux-gnu' }} with: name: licenses diff --git a/.github/workflows/test-vp-create.yml b/.github/workflows/test-vp-create.yml index fcfd31f51c..ea8acbaad8 100644 --- a/.github/workflows/test-vp-create.yml +++ b/.github/workflows/test-vp-create.yml @@ -79,7 +79,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -101,7 +101,7 @@ jobs: ls -la tmp/tgz - name: Upload tgz artifacts - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-plus-packages path: tmp/tgz/ @@ -160,12 +160,12 @@ jobs: steps: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version: 24 - name: Download vite-plus packages - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: vite-plus-packages path: tmp/tgz From 18b1d359b6f140936162ad7e79a1a6350fc10db5 Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 11 May 2026 20:39:13 +0800 Subject: [PATCH 2/5] style(ci): normalize yaml spacing before version comments --- .github/actions/build-upstream/action.yml | 4 ++-- .../download-rolldown-binaries/action.yml | 2 +- .github/workflows/ci.yml | 8 ++++---- .github/workflows/e2e-test.yml | 8 ++++---- .github/workflows/release.yml | 16 ++++++++-------- .github/workflows/test-vp-create.yml | 8 ++++---- 6 files changed, 23 insertions(+), 23 deletions(-) diff --git a/.github/actions/build-upstream/action.yml b/.github/actions/build-upstream/action.yml index 5e7c702e8a..3cb0e19f75 100644 --- a/.github/actions/build-upstream/action.yml +++ b/.github/actions/build-upstream/action.yml @@ -36,7 +36,7 @@ runs: # Cache NAPI bindings and Rust CLI binary (the slow parts, especially on Windows) - name: Restore NAPI binding cache id: cache-restore - uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 + uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | packages/cli/binding/*.node @@ -151,7 +151,7 @@ runs: - name: Save NAPI binding cache if: steps.cache-restore.outputs.cache-hit != 'true' - uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 + uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 with: path: | packages/cli/binding/*.node diff --git a/.github/actions/download-rolldown-binaries/action.yml b/.github/actions/download-rolldown-binaries/action.yml index faea59be4f..79331660b4 100644 --- a/.github/actions/download-rolldown-binaries/action.yml +++ b/.github/actions/download-rolldown-binaries/action.yml @@ -50,7 +50,7 @@ runs: fi env: GITHUB_TOKEN: ${{ inputs.github-token }} - - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 + - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 if: ${{ inputs.upload == 'true' }} with: name: rolldown-binaries diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1b136e91f5..8a7c5a8fe3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -230,7 +230,7 @@ jobs: - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -698,7 +698,7 @@ jobs: - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -742,7 +742,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -821,7 +821,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index 461683407a..baee96cc40 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -94,7 +94,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -117,7 +117,7 @@ jobs: ls -la tmp/tgz - name: Upload tgz artifacts - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-plus-packages-${{ matrix.os }} path: tmp/tgz/ @@ -373,13 +373,13 @@ jobs: shell: powershell run: Set-MpPreference -DisableRealtimeMonitoring $true - - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version: ${{ matrix.project.node-version }} package-manager-cache: false - name: Download vite-plus packages - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: vite-plus-packages-${{ matrix.os }} path: tmp/tgz diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c509d27e11..ae1ca304a8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -75,7 +75,7 @@ jobs: - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v5.0.0 - - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version-file: .node-version package-manager-cache: false @@ -86,34 +86,34 @@ jobs: run: pnpm install - name: Download cli dist - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/dist pattern: cli merge-multiple: true - name: Download cli docs - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/docs pattern: cli-docs merge-multiple: true - name: Download cli binding - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/cli/artifacts pattern: vite-plus-native-* - name: Download core dist - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages/core/dist pattern: core merge-multiple: true - name: Download LICENSE files - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: packages pattern: licenses @@ -126,13 +126,13 @@ jobs: upload: 'false' - name: Download Rust CLI binaries - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: rust-cli-artifacts pattern: vite-global-cli-* - name: Download installer binaries (Windows) - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: installer-artifacts pattern: vp-setup-* diff --git a/.github/workflows/test-vp-create.yml b/.github/workflows/test-vp-create.yml index ea8acbaad8..b8d6039f7c 100644 --- a/.github/workflows/test-vp-create.yml +++ b/.github/workflows/test-vp-create.yml @@ -79,7 +79,7 @@ jobs: - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 - - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: rolldown-binaries path: ./rolldown/packages/rolldown/src @@ -101,7 +101,7 @@ jobs: ls -la tmp/tgz - name: Upload tgz artifacts - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: name: vite-plus-packages path: tmp/tgz/ @@ -160,12 +160,12 @@ jobs: steps: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 + - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 with: node-version: 24 - name: Download vite-plus packages - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 + uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: name: vite-plus-packages path: tmp/tgz From 18678aa7fb0e7d17f13e0e87601b7ce508893d2d Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 11 May 2026 20:44:46 +0800 Subject: [PATCH 3/5] docs(ci): note graphite-ci-action node20 deprecation pending upstream fix --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a7c5a8fe3..4a22ca6171 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,6 +30,8 @@ jobs: steps: - name: Optimize CI id: check_skip + # v0.0.9 still declares `using: node20`; emits a Node 20 deprecation warning until upstream ships a node24 release. + # https://github.com/withgraphite/graphite-ci-action uses: withgraphite/graphite-ci-action@9bc969adfd43bb790da3b64b543c78c75cef9689 # v0.0.9 with: graphite_token: ${{ secrets.GRAPHITE_CI_OPTIMIZER_TOKEN }} From 35f8d9dcb88ac85231b4bc7fe6c027b4acaa2b5b Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 11 May 2026 20:48:49 +0800 Subject: [PATCH 4/5] chore(ci): bump oxc-project/setup-node to v1.3.0 for node24 pnpm/action-setup --- .github/workflows/ci.yml | 10 +++++----- .github/workflows/e2e-test.yml | 2 +- .github/workflows/reusable-release-build.yml | 2 +- .github/workflows/test-vp-create.yml | 2 +- .github/workflows/upgrade-deps.yml | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a22ca6171..b01abc15a0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -181,7 +181,7 @@ jobs: with: files: . - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile @@ -227,7 +227,7 @@ jobs: cache-key: cli-e2e-test-${{ matrix.target }} target-dir: ${{ runner.os == 'Windows' && format('{0}/target', env.DEV_DRIVE) || '' }} - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile @@ -695,7 +695,7 @@ jobs: cache-key: cli-snap-test-${{ matrix.target }} target-dir: ${{ runner.os == 'Windows' && format('{0}/target', env.DEV_DRIVE) || '' }} - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - name: Install docs dependencies run: pnpm -C docs install --frozen-lockfile @@ -742,7 +742,7 @@ jobs: save-cache: ${{ github.ref_name == 'main' }} cache-key: cli-e2e-test-musl - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: @@ -821,7 +821,7 @@ jobs: save-cache: ${{ github.ref_name == 'main' }} cache-key: install-e2e-test - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index baee96cc40..cd7d9c3717 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -92,7 +92,7 @@ jobs: save-cache: ${{ github.ref_name == 'main' }} cache-key: e2e-build-${{ matrix.os }} - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: diff --git a/.github/workflows/reusable-release-build.yml b/.github/workflows/reusable-release-build.yml index 3facdd51ff..0f18b699bc 100644 --- a/.github/workflows/reusable-release-build.yml +++ b/.github/workflows/reusable-release-build.yml @@ -56,7 +56,7 @@ jobs: - name: Rustup Adds Target run: rustup target add ${{ matrix.settings.target }} - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - name: Set binding version shell: bash diff --git a/.github/workflows/test-vp-create.yml b/.github/workflows/test-vp-create.yml index b8d6039f7c..6d4efa88b6 100644 --- a/.github/workflows/test-vp-create.yml +++ b/.github/workflows/test-vp-create.yml @@ -77,7 +77,7 @@ jobs: save-cache: ${{ github.ref_name == 'main' }} cache-key: create-e2e-build - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: diff --git a/.github/workflows/upgrade-deps.yml b/.github/workflows/upgrade-deps.yml index 80a0c13103..763ccb4a40 100644 --- a/.github/workflows/upgrade-deps.yml +++ b/.github/workflows/upgrade-deps.yml @@ -29,7 +29,7 @@ jobs: cache-key: upgrade-deps tools: just,cargo-shear - - uses: oxc-project/setup-node@4c26e7cb3605b6bdef5450dacd02c434b10fd8ba # v1.2.0 + - uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0 - name: Rustup Adds Target run: rustup target add x86_64-unknown-linux-gnu From 9c0187668eba9646cee8209bb0ac01a32335c12d Mon Sep 17 00:00:00 2001 From: MK Date: Mon, 11 May 2026 21:00:46 +0800 Subject: [PATCH 5/5] chore(ci): pin oxc-project/setup-rust to main for node24 rust-cache --- .github/workflows/ci.yml | 12 ++++++------ .github/workflows/deny.yml | 2 +- .github/workflows/e2e-test.yml | 2 +- .github/workflows/reusable-release-build.yml | 2 +- .github/workflows/test-standalone-install.yml | 2 +- .github/workflows/test-vp-create.yml | 2 +- .github/workflows/upgrade-deps.yml | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b01abc15a0..998570475f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,7 @@ jobs: CARGO_HOME,{{ DEV_DRIVE }}/.cargo RUSTUP_HOME,{{ DEV_DRIVE }}/.rustup - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: test @@ -164,7 +164,7 @@ jobs: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - uses: ./.github/actions/clone - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: lint @@ -221,7 +221,7 @@ jobs: CARGO_HOME,{{ DEV_DRIVE }}/.cargo RUSTUP_HOME,{{ DEV_DRIVE }}/.rustup - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: cli-e2e-test-${{ matrix.target }} @@ -689,7 +689,7 @@ jobs: shell: bash run: mkdir -p "$TEMP" "$TMP" - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: cli-snap-test-${{ matrix.target }} @@ -737,7 +737,7 @@ jobs: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - uses: ./.github/actions/clone - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: cli-e2e-test-musl @@ -816,7 +816,7 @@ jobs: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - uses: ./.github/actions/clone - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: install-e2e-test diff --git a/.github/workflows/deny.yml b/.github/workflows/deny.yml index cd551f041c..9cad139902 100644 --- a/.github/workflows/deny.yml +++ b/.github/workflows/deny.yml @@ -41,7 +41,7 @@ jobs: path: rolldown ref: ${{ steps.upstream-versions.outputs.ROLLDOWN_HASH }} - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: restore-cache: false # Pinned to 0.18.6+ for CVSS 4.0 support (EmbarkStudios/cargo-deny#805) diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml index cd7d9c3717..03c3830ca3 100644 --- a/.github/workflows/e2e-test.yml +++ b/.github/workflows/e2e-test.yml @@ -87,7 +87,7 @@ jobs: shell: powershell run: Set-MpPreference -DisableRealtimeMonitoring $true - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: e2e-build-${{ matrix.os }} diff --git a/.github/workflows/reusable-release-build.yml b/.github/workflows/reusable-release-build.yml index 0f18b699bc..3c5d53ec0c 100644 --- a/.github/workflows/reusable-release-build.yml +++ b/.github/workflows/reusable-release-build.yml @@ -48,7 +48,7 @@ jobs: steps: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - uses: ./.github/actions/clone - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: ${{ inputs.cache-key }} diff --git a/.github/workflows/test-standalone-install.yml b/.github/workflows/test-standalone-install.yml index 2c780dc708..c132187e73 100644 --- a/.github/workflows/test-standalone-install.yml +++ b/.github/workflows/test-standalone-install.yml @@ -807,7 +807,7 @@ jobs: CARGO_HOME,{{ DEV_DRIVE }}/.cargo RUSTUP_HOME,{{ DEV_DRIVE }}/.rustup - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: target-dir: ${{ format('{0}/target', env.DEV_DRIVE) }} diff --git a/.github/workflows/test-vp-create.yml b/.github/workflows/test-vp-create.yml index 6d4efa88b6..50fe50e4e0 100644 --- a/.github/workflows/test-vp-create.yml +++ b/.github/workflows/test-vp-create.yml @@ -72,7 +72,7 @@ jobs: - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2 - uses: ./.github/actions/clone - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: create-e2e-build diff --git a/.github/workflows/upgrade-deps.yml b/.github/workflows/upgrade-deps.yml index 763ccb4a40..28b84e904e 100644 --- a/.github/workflows/upgrade-deps.yml +++ b/.github/workflows/upgrade-deps.yml @@ -23,7 +23,7 @@ jobs: - name: Set up metadata directory run: echo "UPGRADE_DEPS_META_DIR=${RUNNER_TEMP}/upgrade-deps-meta" >> "$GITHUB_ENV" - - uses: oxc-project/setup-rust@23f38cfb0c04af97a055f76acee94d5be71c7c82 # v1.0.16 + - uses: oxc-project/setup-rust@68c3199c5339f965e6e163924c3c450773eba42b # main (pending v1.0.17 — Swatinem/rust-cache v2.9.1 for node24) with: save-cache: ${{ github.ref_name == 'main' }} cache-key: upgrade-deps