diff --git a/include/vsg/core/Export.h b/include/vsg/core/Export.h index c5b5941f9d..d43003c6e2 100644 --- a/include/vsg/core/Export.h +++ b/include/vsg/core/Export.h @@ -16,7 +16,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI # pragma warning(disable : 4251) #endif -#if defined(WIN32) +#if defined(_WIN32) # if defined(vsg_EXPORTS) # define VSG_DECLSPEC __declspec(dllexport) # elif defined(VSG_SHARED_LIBRARY) diff --git a/include/vsg/core/IntrusiveAllocator.h b/include/vsg/core/IntrusiveAllocator.h index 9aa3ec402d..131a33a320 100644 --- a/include/vsg/core/IntrusiveAllocator.h +++ b/include/vsg/core/IntrusiveAllocator.h @@ -106,6 +106,7 @@ namespace vsg Element() = default; Element(const Element&) = default; + Element& operator=(const Element&) = default; }; struct FreeList diff --git a/include/vsg/platform/win32/Win32_Window.h b/include/vsg/platform/win32/Win32_Window.h index bfcd588b22..54755cf159 100644 --- a/include/vsg/platform/win32/Win32_Window.h +++ b/include/vsg/platform/win32/Win32_Window.h @@ -41,7 +41,6 @@ namespace vsgWin32 uint16_t modifierMask = 0; // see https://learn.microsoft.com/en-us/windows/win32/inputdev/about-keyboard-input#keystroke-message-flags - WORD vkCode = LOWORD(wParam); // virtual-key code WORD keyFlags = HIWORD(lParam); WORD scanCode = LOBYTE(keyFlags); // scan code BOOL isExtendedKey = (keyFlags & KF_EXTENDED) == KF_EXTENDED; // extended-key flag, 1 if scancode has 0xE0 prefix diff --git a/include/vsg/vk/State.h b/include/vsg/vk/State.h index 1f82b20e13..170ecbdba4 100644 --- a/include/vsg/vk/State.h +++ b/include/vsg/vk/State.h @@ -19,7 +19,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI #include #include -#include #include namespace vsg @@ -33,7 +32,8 @@ namespace vsg class StateStack { public: - StateStack() {} + StateStack() = default; + StateStack(const StateStack& rhs) = default; using Stack = std::array; Stack stack; diff --git a/src/vsg/io/FileSystem.cpp b/src/vsg/io/FileSystem.cpp index 45c83fe082..4bbf9e2ce6 100644 --- a/src/vsg/io/FileSystem.cpp +++ b/src/vsg/io/FileSystem.cpp @@ -17,7 +17,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI #include -#if defined(WIN32) && !defined(__CYGWIN__) +#if defined(_WIN32) && !defined(__CYGWIN__) # include # include # include @@ -223,7 +223,7 @@ Path vsg::executableFilePath() { Path path; -#if defined(WIN32) +#if defined(_WIN32) TCHAR buf[PATH_MAX + 1]; DWORD result = GetModuleFileName(NULL, buf, static_cast(std::size(buf) - 1)); if (result && result < std::size(buf)) diff --git a/src/vsg/utils/PolytopeIntersector.cpp b/src/vsg/utils/PolytopeIntersector.cpp index bc60959657..0fc498b8fb 100644 --- a/src/vsg/utils/PolytopeIntersector.cpp +++ b/src/vsg/utils/PolytopeIntersector.cpp @@ -78,7 +78,7 @@ namespace vsg { size_t numNegativeDistances = 0; size_t numPositiveDistances = 0; - size_t numZeroDistances = 0; + [[maybe_unused]] size_t numZeroDistances = 0; processedDistances.resize(0); for (const auto& v : processedVertices) {