fix(types/custom-element): defineCustomElement with required props#11578
Merged
yyx990803 merged 1 commit intovuejs:minorfrom Aug 15, 2024
Merged
fix(types/custom-element): defineCustomElement with required props#11578yyx990803 merged 1 commit intovuejs:minorfrom
defineCustomElement with required props#11578yyx990803 merged 1 commit intovuejs:minorfrom
Conversation
edison1105
added a commit
to edison1105/vuejs-core
that referenced
this pull request
Aug 16, 2024
…d props (vuejs#11578)" This reverts commit 77d5e88.
yyx990803
pushed a commit
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes type error when using
defineCustomElementwithrequired: trueprops.In addition, this PR also removes an unnecessary
ExtractPropTypes. Before this change:After this change: